Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional checks to NativeECDHKeyAgreement to match upstream #781

Merged
merged 1 commit into from
May 23, 2024
Merged

Add additional checks to NativeECDHKeyAgreement to match upstream #781

merged 1 commit into from
May 23, 2024

Conversation

KostasTsiounis
Copy link
Contributor

There are additional checks that are required during the init and doPhase parts of ECDH key agreement. Those checks are already present in the original ECDHKeyAgreement class, so they had to be added to the NativeECDHKeyAgreement class as well.

Back-ported from: ibmruntimes/openj9-openjdk-jdk#788

Signed-off by: Kostas Tsiounis kostas.tsiounis@ibm.com

@KostasTsiounis
Copy link
Contributor Author

FYI @keithc-ca

@keithc-ca keithc-ca self-requested a review May 15, 2024 14:59
@KostasTsiounis KostasTsiounis requested a review from keithc-ca May 22, 2024 19:01
@keithc-ca
Copy link
Member

Jenkins test sanity alinux jdk11

@keithc-ca
Copy link
Member

Grinders passed:

@keithc-ca keithc-ca merged commit d22b1db into ibmruntimes:openj9 May 23, 2024
5 checks passed
@KostasTsiounis KostasTsiounis deleted the ecdh_change branch May 28, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KostasTsiounis @keithc-ca