Update gcp-common/IAM Credentials API usage #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to: - github.com/hashicorp/go-gcp-common@service-account-update - google.golang.org/api/iamcredentials/v1@v0.45.0 Updates how we sign JWTs, to use supported methods. See also: - #100 - https://cloud.google.com/iam/docs/migrating-to-credentials-api#iam-sign-jwt-go
calvn
reviewed
Apr 22, 2021
This was referenced Apr 23, 2021
Closed
calvn
reviewed
Apr 23, 2021
This was referenced Apr 26, 2021
catsby
changed the title
calvn
previously approved these changes
Apr 27, 2021
austingebauer
previously approved these changes
Apr 28, 2021
There was a problem hiding this comment.
I think this project parameter can be removed from the CLI help text?
Otherwise, LGTM 👍
austingebauer
approved these changes
Apr 28, 2021
catsby
added a commit
that referenced
this pull request
Apr 29, 2021
* test-acc step should take TEST args * allow optional TESTARGS to test step * Update JWT signing Updates to: - github.com/hashicorp/go-gcp-common@service-account-update - google.golang.org/api/iamcredentials/v1@v0.45.0 Updates how we sign JWTs, to use supported methods. See also: - #100 - https://cloud.google.com/iam/docs/migrating-to-credentials-api#iam-sign-jwt-go * commit go.sum * revert/update vendor * update / revert back to pre-updates * just update this part * not sure why this wasn't picked up before * formatting * update * update dep * update go-gcp-common to tag v0.7.0 * update string used to auth with signjwt * remove project help text
This was referenced Apr 29, 2021
catsby
added
backport/vault-1.6.x
backport/vault-1.5.x
and removed
backport/vault-1.5.x
backport/vault-1.6.x
backport/vault-1.7.x
labels
This was referenced Apr 29, 2021
This was referenced Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates how we sign JWTs, to use supported methods and move away from deprecated methods. The
SignJWTmethod in the IAM library we're using is deprecated. The migration guide says to move the the IAM Service Account Credentials API for that method instead. The other methods we use in the IAM library appear to be continued to be supported.Updates to:
google.golang.org/api/iamcredentials/v1@v0.45.0ended up leaving this at v0.3.0 to avoid another dependency issueRelated Issues/Pull Requests
Contributor Checklist
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
Tests:
[x] Backwards compatible
According to the tests, this is backwards compatible. This PR only changes the parts were we call
SignJWT, and doesn't remove or otherwise change the usage ofiam/v1, as there are some parts pertaining to UniqueID which are not (?) found in the Service Account Credentials API. The methods in question do not appear to be deprecated.