-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Agent Auth with GCP to use new SignJWT endpoint #11473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit (that would result in a slightly larger diff but ends up being less confusing), otherwise looks good.
calvn
approved these changes
Apr 27, 2021
tvoran
approved these changes
Apr 27, 2021
austingebauer
approved these changes
Apr 27, 2021
tvoran
reviewed
Apr 29, 2021
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
tvoran
approved these changes
Apr 30, 2021
catsby
added a commit
that referenced
this pull request
Apr 30, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint * use iamcredentials name instead of renaming the package on import * add changelog * Update changelog/11473.txt Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
catsby
added a commit
that referenced
this pull request
Apr 30, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint * use iamcredentials name instead of renaming the package on import * add changelog * Update changelog/11473.txt Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
catsby
added a commit
that referenced
this pull request
Apr 30, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint * use iamcredentials name instead of renaming the package on import * add changelog * Update changelog/11473.txt Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
austingebauer
pushed a commit
that referenced
this pull request
May 4, 2021
austingebauer
pushed a commit
that referenced
this pull request
May 6, 2021
calvn
pushed a commit
that referenced
this pull request
May 7, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint * use iamcredentials name instead of renaming the package on import * add changelog * Update changelog/11473.txt Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Vault Agent's GCP auth to use GCP's IAM Service Account Credential endpoint for signing JWTs, as the IAM endpoint versions are deprecated. See https://cloud.google.com/iam/docs/migrating-to-credentials-api for more information on the deprecation and migration.
See also for more backstory: