Backport of Update gcp-common/IAM Credentials API usage into release/vault-1.6.x #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #108 to be assessed for backporting due to the inclusion of the label backport/vault-1.6.x.
The below text is copied from the body of the original PR.
Overview
Updates how we sign JWTs, to use supported methods and move away from deprecated methods. The
SignJWT
method in the IAM library we're using is deprecated. The migration guide says to move the the IAM Service Account Credentials API for that method instead. The other methods we use in the IAM library appear to be continued to be supported.Updates to:
google.golang.org/api/iamcredentials/v1@v0.45.0ended up leaving this at v0.3.0 to avoid another dependency issueRelated Issues/Pull Requests
Contributor Checklist
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
Tests:
[x] Backwards compatible
According to the tests, this is backwards compatible. This PR only changes the parts were we call
SignJWT
, and doesn't remove or otherwise change the usage ofiam/v1
, as there are some parts pertaining to UniqueID which are not (?) found in the Service Account Credentials API. The methods in question do not appear to be deprecated.