Lf/new functions template #205

LisandroFernandezSF · 2020-09-01T21:05:25Z

What does this PR do?

This PR is adding a new project template which copies the same structure than 'empty', but includes a 'functions' folder

What issues does this PR fix or reference?

W-7958785

xyc · 2020-09-01T21:14:52Z

packages/templates/src/templates/project/functions/README.md

@@ -0,0 +1,9 @@
+# Salesforce App


might be helpful if we have some get started info for users here. @smaddox-sf

That's a good suggestion that should be addressed as a separate work item for now.

xyc · 2020-09-01T21:15:07Z

packages/templates/src/utils/types.ts

@@ -107,12 +107,13 @@ export interface LightningTestOptions extends TemplateOptions {
 export interface ProjectOptions extends TemplateOptions {
  projectname: string;
  defaultpackagedir: string;
+  defaultfunctionsdir: string;


Where is this used?

It's not. It was part of another approach. Fixed!

AnanyaJha · 2020-09-01T21:40:59Z

packages/templates/src/generators/projectGenerator.ts

@@ -204,6 +204,18 @@ export default class ProjectGenerator extends SfdxGenerator<ProjectOptions> {
        );
      }
    }
+
+    // tslint:disable-next-line:no-unused-expression
+    if (template === 'functions') {


do we need the tslint disable here? seems like it runs fine without it

…sforcedx-templates into lf/newFunctionsTemplate

packages/templates/src/templates/project/functions/Manifest.xml

lcampos · 2020-09-02T16:58:14Z

packages/templates/src/templates/project/functions/ScratchDef.json

+{
+  "orgName": "<%= company %>",
+  "edition": "Developer",
+  "features": []


I think functions has it's own scratch org feature that we should add here.Let me confirm the name for it.

packages/templates/src/templates/project/functions/ScratchDef.json

…json There is a specific scratch org feature for functions. Co-authored-by: lcampos <lcamposguajardo@gmail.com>

lcampos · 2020-09-02T17:43:44Z

packages/plugin-templates/src/commands/force/project/create.ts

@@ -35,7 +35,7 @@ export default class Project extends TemplateCommand {
      description: MessageUtil.get('ProjectTemplateFlagDescription'),
      longDescription: MessageUtil.get('ProjectTemplateFlagLongDescription'),
      default: 'standard',
-      options: ['standard', 'empty', 'analytics']
+      options: ['standard', 'empty', 'analytics', 'functions']


This is correct but I wonder we might want to keep the functionality strictly to the library for now so that it's not surfaced through the cli command options. What do you think @smaddox-sf ?

Circling back from our conversation during standup, we need to remove the changes on this PR that are on the plugin-templates module. The rest can be merged cc @LisandroFernandezSF

…sforcedx-templates into lf/newFunctionsTemplate

* Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Removing unnecessary type and tslint line * Removing unnecessary type * Update packages/templates/src/templates/project/functions/ScratchDef.json There is a specific scratch org feature for functions. Co-authored-by: lcampos <lcamposguajardo@gmail.com> * I remove code that affects the plugin * empty commit Co-authored-by: lcampos <lcamposguajardo@gmail.com>

* Update contribution guide (#190) * add coding and commit guidelines, start developing doc * update contributing docs * update develop doc, update launch config * Update CONTRIBUTING.md * Update README.md * Update coding-guidelines.md * Update commit-guidelines.md * Update developing.md * Update CONTRIBUTING.md Co-authored-by: Xiaoyi Chen <xchen@salesforce.com> * Update commit-guidelines.md * Update developing.md * Update developing.md * update contributing docs * Update developing.md Co-authored-by: Emily Kapner <ekapner@salesforce.com> * port #186 (#199) * Update dev scripts (#200) @W-8017763@ * Remove @salesforce/templates from yarn.lock (#201) @W-8017763@ * Lf/new functions template (#205) * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Removing unnecessary type and tslint line * Removing unnecessary type * Update packages/templates/src/templates/project/functions/ScratchDef.json There is a specific scratch org feature for functions. Co-authored-by: lcampos <lcamposguajardo@gmail.com> * I remove code that affects the plugin * empty commit Co-authored-by: lcampos <lcamposguajardo@gmail.com> Co-authored-by: Emily Kapner <ekapner@salesforce.com> Co-authored-by: lcampos <lcamposguajardo@gmail.com> Co-authored-by: Lisandro Fernandez <70181900+LisandroFernandezSF@users.noreply.github.com>

LisandroFernandezSF added 2 commits September 1, 2020 14:15

Adding Functions template

b88780e

Adding test for the new template

1c1ff60

LisandroFernandezSF requested a review from a team as a code owner September 1, 2020 21:05

salesforce-cla bot added the cla:signed label Sep 1, 2020

LisandroFernandezSF marked this pull request as draft September 1, 2020 21:06

LisandroFernandezSF changed the base branch from main to develop September 1, 2020 21:07

Removing unnecessary lines and spaces

Unverified

No user is associated with the committer email.

Learn about vigilant mode

e0100ca

xyc reviewed Sep 1, 2020

View reviewed changes

LisandroFernandezSF added 3 commits September 1, 2020 18:30

Adding Functions template

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

9c1150c

Adding test for the new template

Unverified

No user is associated with the committer email.

Learn about vigilant mode

f9dedf4

Removing unnecessary lines and spaces

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

30eb8f1

AnanyaJha reviewed Sep 1, 2020

View reviewed changes

LisandroFernandezSF added 5 commits September 1, 2020 19:05

Removing unnecessary type and tslint line

3de3651

Merge branch 'lf/newFunctionsTemplate' of github.com:forcedotcom/sale…

48947a6

…sforcedx-templates into lf/newFunctionsTemplate

Merge branch 'lf/newFunctionsTemplate' of github.com:forcedotcom/sale…

56e4a40

…sforcedx-templates into lf/newFunctionsTemplate

Merge branch 'lf/newFunctionsTemplate' of github.com:forcedotcom/sale…

a2f7e91

…sforcedx-templates into lf/newFunctionsTemplate

Removing unnecessary type

1ecb297

smithgp reviewed Sep 1, 2020

View reviewed changes

packages/templates/src/templates/project/functions/Manifest.xml Show resolved Hide resolved

lcampos reviewed Sep 2, 2020

View reviewed changes

packages/templates/src/templates/project/functions/ScratchDef.json Outdated Show resolved Hide resolved

Update packages/templates/src/templates/project/functions/ScratchDef.…

7162264

…json There is a specific scratch org feature for functions. Co-authored-by: lcampos <lcamposguajardo@gmail.com>

lcampos reviewed Sep 2, 2020

View reviewed changes

LisandroFernandezSF added 2 commits September 2, 2020 17:13

I remove code that affects the plugin

2877726

Merge branch 'lf/newFunctionsTemplate' of github.com:forcedotcom/sale…

a7f13b1

…sforcedx-templates into lf/newFunctionsTemplate

lcampos approved these changes Sep 2, 2020

View reviewed changes

LisandroFernandezSF marked this pull request as ready for review September 2, 2020 20:22

xyc approved these changes Sep 2, 2020

View reviewed changes

empty commit

f767be2

LisandroFernandezSF merged commit 7569076 into develop Sep 3, 2020

LisandroFernandezSF deleted the lf/newFunctionsTemplate branch September 3, 2020 16:09

xyc mentioned this pull request Sep 11, 2020

Release/v49.9.1 #217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lf/new functions template #205

Lf/new functions template #205

LisandroFernandezSF commented Sep 1, 2020

xyc Sep 1, 2020

lcampos Sep 2, 2020

xyc Sep 1, 2020

LisandroFernandezSF Sep 1, 2020

AnanyaJha Sep 1, 2020 •

edited

Loading

LisandroFernandezSF Sep 1, 2020

lcampos Sep 2, 2020

lcampos Sep 2, 2020

lcampos Sep 2, 2020

Lf/new functions template #205

Lf/new functions template #205

Conversation

LisandroFernandezSF commented Sep 1, 2020

What does this PR do?

What issues does this PR fix or reference?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnanyaJha Sep 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnanyaJha Sep 1, 2020 •

edited

Loading