Remove @salesforce/templates #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Won't this be added to the lockfile any time we do yarn install? Shouldn't lerna or the linking script be able to handle if you want to develop against the local version of the package? |
xyc
approved these changes
Aug 27, 2020
|
@brpowell this won't be added to lock file after install, only after |
xyc
pushed a commit
that referenced
this pull request
Sep 11, 2020
Merged
xyc
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Update contribution guide (#190) * add coding and commit guidelines, start developing doc * update contributing docs * update develop doc, update launch config * Update CONTRIBUTING.md * Update README.md * Update coding-guidelines.md * Update commit-guidelines.md * Update developing.md * Update CONTRIBUTING.md Co-authored-by: Xiaoyi Chen <xchen@salesforce.com> * Update commit-guidelines.md * Update developing.md * Update developing.md * update contributing docs * Update developing.md Co-authored-by: Emily Kapner <ekapner@salesforce.com> * port #186 (#199) * Update dev scripts (#200) @W-8017763@ * Remove @salesforce/templates from yarn.lock (#201) @W-8017763@ * Lf/new functions template (#205) * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Removing unnecessary type and tslint line * Removing unnecessary type * Update packages/templates/src/templates/project/functions/ScratchDef.json There is a specific scratch org feature for functions. Co-authored-by: lcampos <lcamposguajardo@gmail.com> * I remove code that affects the plugin * empty commit Co-authored-by: lcampos <lcamposguajardo@gmail.com> Co-authored-by: Emily Kapner <ekapner@salesforce.com> Co-authored-by: lcampos <lcamposguajardo@gmail.com> Co-authored-by: Lisandro Fernandez <70181900+LisandroFernandezSF@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove @salesforce/templates from yarn.lock to prevent getting the code from npm when developing the repo
What issues does this PR fix or reference?
@W-8017763@