Change default eslint rules to reduce warnings on new code #186
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autointegrator
bot
added
the
port:develop
lcampos
approved these changes
Aug 19, 2020
|
❗️Heads up @lcampos, merge conflicts prevented a successful cherry pick. You can try it out yourself and manually resolve the conflicts with the following steps: |
Merged
xyc
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Update contribution guide (#190) * add coding and commit guidelines, start developing doc * update contributing docs * update develop doc, update launch config * Update CONTRIBUTING.md * Update README.md * Update coding-guidelines.md * Update commit-guidelines.md * Update developing.md * Update CONTRIBUTING.md Co-authored-by: Xiaoyi Chen <xchen@salesforce.com> * Update commit-guidelines.md * Update developing.md * Update developing.md * update contributing docs * Update developing.md Co-authored-by: Emily Kapner <ekapner@salesforce.com> * port #186 (#199) * Update dev scripts (#200) @W-8017763@ * Remove @salesforce/templates from yarn.lock (#201) @W-8017763@ * Lf/new functions template (#205) * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Adding Functions template * Adding test for the new template * Removing unnecessary lines and spaces * Removing unnecessary type and tslint line * Removing unnecessary type * Update packages/templates/src/templates/project/functions/ScratchDef.json There is a specific scratch org feature for functions. Co-authored-by: lcampos <lcamposguajardo@gmail.com> * I remove code that affects the plugin * empty commit Co-authored-by: lcampos <lcamposguajardo@gmail.com> Co-authored-by: Emily Kapner <ekapner@salesforce.com> Co-authored-by: lcampos <lcamposguajardo@gmail.com> Co-authored-by: Lisandro Fernandez <70181900+LisandroFernandezSF@users.noreply.github.com>
|
did this rule ever get moved in? I'm still seeing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disabled several eslint rules to reduce the noise on common aura code including default samples.
What issues does this PR fix or reference?
@W-7982322@