This repository was archived by the owner on Jul 1, 2021. It is now read-only.
Remove constantinople fork from mainnet launch cfg #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
working on the py-evm changes |
|
Blocked on py-evm release. trinity core tests pass when py-evm source is at tip of ethereum/py-evm#1717 |
|
Testing out this PR as a patch against the last release, in #176 |
carver
force-pushed
the
cancel-constantinople
branch
from
cc116d5 to
d8b289b
Compare
Multiple block number by 10x
carver
force-pushed
the
cancel-constantinople
branch
from
d8b289b to
d612e6f
Compare
carver
force-pushed
the
cancel-constantinople
branch
from
d612e6f to
dc5217d
Compare
carver
commented
Jan 17, 2019
| @@ -1,5 +1,5 @@ | |||
| [bumpversion] | |||
| current_version = 0.2.0-alpha.37 | |||
| current_version = 0.1.0-alpha.22 | |||
There was a problem hiding this comment.
This change will be needed to do our first regular bumpversion release on trinity.
carver
commented
Jan 17, 2019
| @@ -21,7 +21,7 @@ | |||
| "eth-utils>=1.3.0,<2", | |||
| "ipython>=6.2.1,<7.0.0", | |||
| "plyvel==1.0.5", | |||
| "py-evm==0.2.0a38", | |||
| "py-evm==0.2.0a40", | |||
There was a problem hiding this comment.
This is the latest version of py-evm that includes the constantiNOPEle change. 41 is the patch release that's actually an older version of py-evm.
carver
commented
Jan 17, 2019
| @@ -94,7 +94,7 @@ | |||
| setup( | |||
| name='trinity', | |||
| # *IMPORTANT*: Don't manually change the version here. Use the 'bumpversion' utility. | |||
| version='0.1.0-alpha.20', | |||
| version='0.1.0-alpha.22', | |||
There was a problem hiding this comment.
This got updated in the patch release, which is not in master.
cburgdorf
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Constantinople likely to be postponed due to re-entrancy concerns.
See:
How was it fixed?
Removed the Constantinople fork number from the mainnet json configSet fork block number by 9876543210
Cute Animal Picture