This repository was archived by the owner on Jul 1, 2021. It is now read-only.
Postpone Constantinople as hotfix release #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
changed the title
|
Yikes, it's going to be a big PITA to deal with the fact that eth & trinity split since the last release. Considering just doing a release of current master instead... |
|
Test failures look to just be two numbers which are off in our chain configuration file. |
carver
force-pushed
the
postpone-constantinople-pr
branch
from
8d28560 to
6592685
Compare
Yeah, I realize now that really the only annoyance is dealing with putting the changes on both branches. I thought it was going to be more problematic. Current thought is that the hotpatch is the best option. |
carver
changed the title
pipermerriam
approved these changes
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Constantinople likely to be postponed due to re-entrancy concerns.
See:
How was it fixed?
Set fork block number by 9876543210
Cute Animal Picture