Remove constantinople fork from mainnet config #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
force-pushed
the
cancel-constantinople
branch
from
b871979 to
dc3428a
Compare
|
Let's wait on merging until there is more agreement about what to do in https://gitter.im/ethereum/AllCoreDevs |
|
Social consensus reached. Ready for merge |
pipermerriam
approved these changes
Jan 15, 2019
eth/chains/mainnet/constants.py
Outdated
| @@ -41,4 +41,4 @@ | |||
| # | |||
| # Constantinople Block | |||
| # | |||
| CONSTANTINOPLE_MAINNET_BLOCK = BlockNumber(7080000) | |||
| CONSTANTINOPLE_MAINNET_BLOCK = BlockNumber(70800000) | |||
There was a problem hiding this comment.
This is too easy to visually confuse, can you make it 999999999999999999 or something equally large and visually distinct.
Added a 0 to the end of the block number
carver
force-pushed
the
cancel-constantinople
branch
from
dc3428a to
81d68f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
See ethereum/trinity#174
How was it fixed?
Remove Constantinople from mainnet configDelay fork by adding 0 to block number. The tests hated it when I removed the fork
Cute Animal Picture