Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating wasm/ symlinks in the update script #49

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

cameel
Copy link
Member

@cameel cameel commented Jul 27, 2020

Depends on #48. Part of ethereum/solidity#9258.

It used to be the responsibility of publish_binary.sh but this script is not a part of the new, manual process of adding binaries to solc-bin. I made update do it instead.

@cameel cameel requested a review from chriseth July 27, 2020 18:25
@cameel cameel self-assigned this Jul 27, 2020
@cameel cameel force-pushed the make-update-script-create-wasm-symlinks branch from 93e181b to c487c04 Compare July 28, 2020 11:35
@chriseth chriseth force-pushed the make-update-script-create-wasm-symlinks branch from c487c04 to a6aff48 Compare July 28, 2020 13:16
@chriseth chriseth changed the base branch from fix-update-script-symlink-race-condition to gh-pages July 28, 2020 13:16
@chriseth
Copy link
Contributor

Rebased.

@chriseth chriseth merged commit 26910cf into gh-pages Jul 28, 2020
@cameel cameel deleted the make-update-script-create-wasm-symlinks branch July 28, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants