Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing wasm symlinks to release 0.6.12 #46

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

cameel
Copy link
Member

@cameel cameel commented Jul 22, 2020

Fixes #45.

@cameel cameel requested a review from chriseth July 22, 2020 19:07
@cameel cameel self-assigned this Jul 22, 2020
@chriseth
Copy link
Contributor

travis job failed because of missing newline...

@cameel
Copy link
Member Author

cameel commented Jul 22, 2020

What? In a symlink? WTF.

@cameel
Copy link
Member Author

cameel commented Jul 22, 2020

Wait, it's probably just that the diff after update is not clean. I'll rerun it locally and see what might be the cause.

@cameel
Copy link
Member Author

cameel commented Jul 22, 2020

Looks like the update script did not update the latest symlink in wasm/ on my machine. Not sure why - I ran the clean version from gh-pages which should have done it. Anyway, rerunning locally to fix it.

@cameel cameel force-pushed the add-missing-wasm-symlinks-for-0.6.12 branch from de9d744 to 2ccf1be Compare July 22, 2020 19:28
@cameel
Copy link
Member Author

cameel commented Jul 22, 2020

Fixed.

I think I know what's going on. It did not wait for wasm/ to be processed (which includes creating symlinks to the new release in emscripten-wasm32/) before it started processing emscripten-wasm32/. It did not see the new symlink and therefore did not update the lists. That's despite doing the second update in a callback which I added specifically to prevent this.

This is the same issue I've just been fighting with after modifying the update script. This means that my changes are fine and the issue is actually already there, just not always reproducible. I'll debug it tomorrow - for now, just rerunning it should be enough to fix this PR.

@cameel
Copy link
Member Author

cameel commented Jul 27, 2020

I just pushed #49 which automates creation of these symlinks.

@cameel cameel deleted the add-missing-wasm-symlinks-for-0.6.12 branch July 28, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants