Fix race condition in symlink creation in the update script #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2020
…onditions - Currently link creation is asynchronous and often completes when the processDir() call has already scanned the directory. This way processDir() misses the new link. - To keep it asynchronous could wait for multiple calls to finish using Promises. But I think that just making it synchronous is less intrusive.
cameel
force-pushed
the
fix-update-script-symlink-race-condition
branch
from
738c7df to
7b3b60c
Compare
chriseth
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue we encountered in #46 (comment). Part of ethereum/solidity#9258.
The problem is that I made processing of
emscripten-wasm32/dir wait untilwasmfinishes processing its files but the link creation that happens at that point is still asynchronous.There are multiple
updateSymlink()calls in a loop so one solution would be to wait for all of them usingPromises. But for simplicity I just madeupdateSymlink()synchronous instead.