[Xamarin.Android.Build.Tasks] Properly quote -libraryjars (#666) #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=32861 Scenario: Build a project in Release configuration with `$(AndroidEnableProguard)`=True on Windows. Expected result: it works! Actual result: It doesn't: C:\Program Files\Java\jdk1.8.0_131\\bin\java.exe -jar ... PROGUARD : error : C:\Program Files (Access is denied) Commit 8467ad6 attempted to fix this by "double-quoting" the `-libraryjars` option. Unfortunately, we inadvertantly *triple*-quoted the value (!) -libraryjars "\"'C:\Program Files (x86)\Android\android-sdk\platforms\android-25\android.jar'\"" The `\"` is unexpected, and problematic. It *should* be: -libraryjars "'C:\Program Files (x86)\Android\android-sdk\platforms\android-25\android.jar'" The "actual" cause -- other than inadequate testing, and a need to run unit tests more frequently on Windows -- is that we used `CommandLineBuilder.AppendSwitchIfNotNull()` with `-libraryjars`. This is problematic because `AppendSwitchIfNotNull()` will "escape" embedded double-quotes, which is what is introducing the `\"` quotes and the 3rd level of quoting. Use `CommandLineBuilder.AppendSwitchUnquotedIfNotNull()` instead, to avoid the extra and erroneous quoting. Additionally, `-include` needs double-quoting as well on Windows. Fixup `-include` generation in the `<Proguard/>` and `<CreateMultiDexMainDexClassList/>` tasks.
jonpryor
pushed a commit
that referenced
this pull request
Jun 26, 2020
Changes: dotnet/java-interop@1de5501...60efc99 Fixes: dotnet/java-interop#639 Fixes: dotnet/java-interop#664 * dotnet/java-interop@60efc99: Update to NUnit 3.12/etc. (#667) * dotnet/java-interop@de35d29: [jnimarshalmethod-gen] support methods with 14+ arguments (#670) * dotnet/java-interop@fd2c94e: [generator] Mark protected types nested in sealed classes as private (#672) * dotnet/java-interop@11b7f85: [Java.Interop+MonoAndroid] Remove NullableAttributes.cs, avoid CS0436 (#671) * dotnet/java-interop@ef1d37b: [tools] Add response file support (#665) * dotnet/java-interop@1383981: [logcat-parse] Support the Android 10 `logcat` format (#663)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=32861
Scenario: Build a project in Release configuration with
$(AndroidEnableProguard)=True on Windows.Expected result: it works!
Actual result: It doesn't:
Commit 8467ad6 attempted to fix this by "double-quoting" the
-libraryjarsoption. Unfortunately, we inadvertantly triple-quotedthe value (!)
The
\"is unexpected, and problematic. It should be:The "actual" cause -- other than inadequate testing, and a need to run
unit tests more frequently on Windows -- is that we used
CommandLineBuilder.AppendSwitchIfNotNull()with-libraryjars.This is problematic because
AppendSwitchIfNotNull()will "escape"embedded double-quotes, which is what is introducing the
\"quotesand the 3rd level of quoting.
Use
CommandLineBuilder.AppendSwitchUnquotedIfNotNull()instead, toavoid the extra and erroneous quoting.
Additionally,
-includeneeds double-quoting as well on Windows.Fixup
-includegeneration in the<Proguard/>and<CreateMultiDexMainDexClassList/>tasks.