-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to xamarin/java.interop/master@60efc990c #4867
Conversation
Squash-and-merge commit message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release notes approved, with a couple possible tiny additions that can be added in these draft notes or that I can add later when combining notes.
In addition to the little change for dotnet/java-interop#672, I'll also plan to add a quick note for Java.Interop GitHub 664 too since in theory users could have seen that behavior. Something like:
- [Java.Interop GitHub 664](https://github.com/xamarin/java.interop/issues/664):
For bindings projects, _warning MSB6002: The command-line for the
"BindingsGenerator" task is too long._ could appear when building projects
with long directory names. The build process now uses response files to
prevent this.
Documentation/release-notes/4867.md
Outdated
|
||
#### Android API bindings | ||
|
||
Nested types with `protected` visibility within `sealed` types are now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. By default, I'll probably end up placing this under the Issues fixed section of the notes, and so I'll put the Java.Interop PR number at the beginning to make it look like the other issues fixed. I'll probably also add a quick appearance of the word "Java" to help front-load the information about which side of the bindings process the change affects:
- [Java.Interop GitHub PR 672](https://github.com/xamarin/java.interop/pull/672):
In bindings projects, nested Java types with ...
No description provided.