Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to xamarin/java.interop/master@60efc990c #4867

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jun 25, 2020

No description provided.

@jpobst jpobst requested a review from jonpryor as a code owner June 25, 2020 15:27
@jonpryor
Copy link
Member

Squash-and-merge commit message:

Change: https://github.com/xamarin/java.interop/compare/1de5501b2d49df3d8d3b187df026d611996a67da...60efc990cf7d33a55ff7864f215569d14ce51e34

Fixes: https://github.com/xamarin/java.interop/issues/639
Fixes: https://github.com/xamarin/java.interop/issues/664

  * xamarin/Java.Interop@60efc99: Update to NUnit 3.12/etc. (#667)
  * xamarin/Java.Interop@de35d29: [jnimarshalmethod-gen] support methods with 14+ arguments (#670)
  * xamarin/Java.Interop@fd2c94e: [generator] Mark protected types nested in sealed classes as private (#672)
  * xamarin/Java.Interop@11b7f85: [Java.Interop+MonoAndroid] Remove NullableAttributes.cs, avoid CS0436 (#671)
  * xamarin/Java.Interop@ef1d37b: [tools] Add response file support (#665)
  * xamarin/Java.Interop@1383981: [logcat-parse] Support the Android 10 `logcat` format (#663)

@jpobst jpobst requested a review from brendanzagaeski as a code owner June 26, 2020 15:13
Copy link
Contributor

@brendanzagaeski brendanzagaeski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes approved, with a couple possible tiny additions that can be added in these draft notes or that I can add later when combining notes.

In addition to the little change for dotnet/java-interop#672, I'll also plan to add a quick note for Java.Interop GitHub 664 too since in theory users could have seen that behavior. Something like:

- [Java.Interop GitHub 664](https://github.com/xamarin/java.interop/issues/664):
  For bindings projects, _warning MSB6002: The command-line for the
  "BindingsGenerator" task is too long._ could appear when building projects
  with long directory names.  The build process now uses response files to
  prevent this.


#### Android API bindings

Nested types with `protected` visibility within `sealed` types are now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. By default, I'll probably end up placing this under the Issues fixed section of the notes, and so I'll put the Java.Interop PR number at the beginning to make it look like the other issues fixed. I'll probably also add a quick appearance of the word "Java" to help front-load the information about which side of the bindings process the change affects:

- [Java.Interop GitHub PR 672](https://github.com/xamarin/java.interop/pull/672):
  In bindings projects, nested Java types with ...

@jonpryor jonpryor merged commit 73e91a9 into master Jun 26, 2020
@jonpryor jonpryor deleted the ji-bump-june-25 branch June 26, 2020 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants