Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Android.Runtime.JavaProxyThrowable inherit Java.Lang.Error #663

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

grendello
Copy link
Contributor

Android's Zygote process, responsible for starting and initializing
of every app as well as catching any application crashes (exceptions
not handled by the app, most of the time), special-cases application
exceptions of types Java.Lang.Error and Java.Lang.Exception (and their
derivatives) and this may cause issues with automatic crash reporting
recently added to the Google's Developer Console. The automatically collected
reports do not contain the full trace of our exceptions.

This change hopefully fixes the issue.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=56653

Android's Zygote process, responsible for starting and initializing
of every app as well as catching any application crashes (exceptions
not handled by the app, most of the time), special-cases application
exceptions of types Java.Lang.Error and Java.Lang.Exception (and their
derivatives) and this may cause issues with automatic crash reporting
recently added to the Google's Developer Console. The automatically collected
reports do not contain the full trace of our exceptions.

This change hopefully fixes the issue.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=56653
@jonpryor jonpryor merged commit 2b950f1 into dotnet:master Jun 22, 2017
@grendello grendello deleted the bug56653 branch June 22, 2017 17:04
jonpryor pushed a commit that referenced this pull request Jun 22, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=56653

Android's Zygote process, responsible for starting and initializing
of every app as well as catching any application crashes (exceptions
not handled by the app, most of the time), special-cases application
exceptions of types java.lang.Error and java.lang.Exception (and their
derivatives) and this may cause issues with automatic crash reporting
recently added to the Google's Developer Console. The automatically collected
reports do not contain the full trace of our exceptions.

This change hopefully fixes the issue.
jonpryor pushed a commit that referenced this pull request Jun 26, 2020
Changes: dotnet/java-interop@1de5501...60efc99

Fixes: dotnet/java-interop#639
Fixes: dotnet/java-interop#664

  * dotnet/java-interop@60efc99: Update to NUnit 3.12/etc. (#667)
  * dotnet/java-interop@de35d29: [jnimarshalmethod-gen] support methods with 14+ arguments (#670)
  * dotnet/java-interop@fd2c94e: [generator] Mark protected types nested in sealed classes as private (#672)
  * dotnet/java-interop@11b7f85: [Java.Interop+MonoAndroid] Remove NullableAttributes.cs, avoid CS0436 (#671)
  * dotnet/java-interop@ef1d37b: [tools] Add response file support (#665)
  * dotnet/java-interop@1383981: [logcat-parse] Support the Android 10 `logcat` format (#663)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants