PR wording change suggestion #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the new label style Signed-off-by: Scott Rigby <scott@r6by.com>
davidkarlsen
pushed a commit
that referenced
this pull request
Jan 28, 2019
* # This is a combination of 2 commits. # This is the 1st commit message: Initial commit Signed-off-by: Max Williams <max.williams@deliveryhero.com> # This is the commit message #2: updating sources * Commit Sign-off Signed-off-by: Miguel Angel Mingorance Fernandez <miguel.mingorance@deliveryhero.com> * Updating README table Signed-off-by: Miguel Angel Mingorance Fernandez <miguel.mingorance@deliveryhero.com>
davidkarlsen
pushed a commit
that referenced
this pull request
Jul 25, 2019
* [stable/grafana] Allow secrets for sidecar (helm#13492) Updated the sidecar image to version 0.0.18 This allows also using secrets for volume mounts This way the dashboard and datasource import can be extended to those datatypes Signed-off-by: Sergej Herbert <herbert.sergej@gmail.com> * [stable/grafana] Allow secret - review (helm#13492) - keep the appVersion the same - bump minor version - add missing apostrophe Signed-off-by: Sergej Herbert <herbert.sergej@gmail.com> * [stable/grafana] Allow secret - review #2 (helm#13492) - enable sidecar resource secrets and configmaps by default - update readme to indicate secret preference for datasources Signed-off-by: Sergej Herbert <herbert.sergej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For helm#7696