Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR wording change suggestion #2

Merged
merged 1 commit into from
Dec 1, 2018
Merged

PR wording change suggestion #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions REVIEW_GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,11 @@ Stable charts should not depend on charts in incubator.

Resources and labels should follow some conventions.

**NOTE:**
*The guidelines for standard labels have changed, but due to labels being immutable when using apps/v1, charts with the
legacy labels should continue to use the old label-style, while new charts should start using the updated labels.*
**NOTE:**
*The guidelines for standard labels [have changed](https://github.com/helm/helm/issues/4335). However, since labels are immutable when using apps/v1, and the legacy labels still function, updating a chart from legacy to new labels would be an unnecessary breaking change. Therefore, charts with legacy labels should continue to use them until another breaking change pull request presents an opportunity to also update to the new label style in one MAJOR version bump.*

Updated labels, [full list with comments can be found in the best practices guide](https://github.com/helm/helm/blob/master/docs/chart_best_practices/labels.md)


```yaml
name: {{ template "myapp.fullname" . }}
labels:
Expand Down