Skip to content

Commit

Permalink
Merge pull request #2 from scottrigby/labelDocs
Browse files Browse the repository at this point in the history
PR wording change suggestion
  • Loading branch information
davidkarlsen authored Dec 1, 2018
2 parents 4fed7a2 + 0fa1f94 commit a029616
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions REVIEW_GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,11 @@ Stable charts should not depend on charts in incubator.

Resources and labels should follow some conventions.

**NOTE:**
*The guidelines for standard labels have changed, but due to labels being immutable when using apps/v1, charts with the
legacy labels should continue to use the old label-style, while new charts should start using the updated labels.*
**NOTE:**
*The guidelines for standard labels [have changed](https://github.com/helm/helm/issues/4335). However, since labels are immutable when using apps/v1, and the legacy labels still function, updating a chart from legacy to new labels would be an unnecessary breaking change. Therefore, charts with legacy labels should continue to use them until another breaking change pull request presents an opportunity to also update to the new label style in one MAJOR version bump.*

Updated labels, [full list with comments can be found in the best practices guide](https://github.com/helm/helm/blob/master/docs/chart_best_practices/labels.md)


```yaml
name: {{ template "myapp.fullname" . }}
labels:
Expand Down

0 comments on commit a029616

Please sign in to comment.