Enabling unit tests #250
Enabling unit tests #250
Conversation
|
|
|
@ctaggart ping |
| { | ||
| var task = new CreateTask(); | ||
| Assert.Equal("https://raw.githubusercontent.com/ctaggart/sourcelink-test/{commit}/*", task.ConvertUrl(provided)); | ||
| } |
| <Content Include="$(OutputPath)net461/SourceLink.Create.BitBucket.dll"> | ||
| <Pack>true</Pack> | ||
| <PackagePath>build/net461</PackagePath> | ||
| </Content> |
There was a problem hiding this comment.
Why was this removed? Is it not needed anymore?
There was a problem hiding this comment.
My understanding is that <pack> is responsible to generate a nuget package. Why do we need to create a package in the Tests project?
Not to mention I couldn't compile with this in place.
There was a problem hiding this comment.
This file is SourceLink.Create.BitBucket.csproj. If you compare the nupkgs between 2.2.1 and this build, you will see that you are missing those libraries.
https://ci.appveyor.com/project/ctaggart/sourcelink/build/2.2.1/artifacts
https://ci.appveyor.com/project/ctaggart/sourcelink/build/2.2.0-b538/artifacts
There was a problem hiding this comment.
Ah, ok. I'll have a look at the csproj files changes to ensure only Tests project is affected.
| <Compile Remove="bin\**" /> | ||
| <EmbeddedResource Remove="bin\**" /> | ||
| <None Remove="bin\**" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Might need to revert that.
|
Do you know what else needs to be done to get the tests to show up here? |
|
I'll be able to review again when I get back from vacation. I'll be gone for a week. |
|
Closing in favor of #251 |
Fixes #236 to unblock #240
@ctaggart please review