Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

Added Bitbucket Server regex for urls. #249

Closed
wants to merge 1 commit into from
Closed

Added Bitbucket Server regex for urls. #249

wants to merge 1 commit into from

Conversation

chris5287
Copy link
Contributor

@chris5287 chris5287 commented Sep 5, 2017

This adds support for Bitbucket server urls, which are different to Bitbucket cloud urls (see #180)

Example code running: https://dotnetfiddle.net/gZWblj

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
@chris5287
Copy link
Contributor Author

@ctaggart ping it would be great to get these changes in the next release please!

@ctaggart
Copy link
Owner

ctaggart commented Sep 9, 2017

Thanks for this contribution! This depends on the unit testing #250 being merged first. This will need some unit tests. As is right now, this will probably break SourceLink.Create.CommandLine:

https://github.com/ctaggart/SourceLink/blob/master/SourceLink.Create.CommandLine/CreateTask.cs#L68-L78

This code should probably go in a:
SourceLink.Create.BitbucketServer.UrlConverter

The original intention was that we would create a nupkg of:
SourceLink.Create.BitbucketServer

But then we decided to add multiple implementations to SourceLink.Create.CommandLine. Were you wanting to use this new UrlConverter with the CommandLine version or the Libgit2 based creates?

fyi, I'm on vacation for a week starting now, so I'll respond when I get back.

@chris5287 chris5287 closed this Sep 13, 2017
@chris5287 chris5287 deleted the feature/bitbucket-server branch September 13, 2017 21:03
@chris5287 chris5287 restored the feature/bitbucket-server branch September 13, 2017 21:04
@chris5287 chris5287 deleted the feature/bitbucket-server branch September 13, 2017 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants