Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

get unit tests running #236

Closed
ctaggart opened this issue Aug 18, 2017 · 7 comments
Closed

get unit tests running #236

ctaggart opened this issue Aug 18, 2017 · 7 comments

Comments

@ctaggart
Copy link
Owner

No description provided.

@SeanFeldman
Copy link
Contributor

@ctaggart what was the intent for SourceLink.Test and Tests? Can I get rid of one?

@ctaggart
Copy link
Owner Author

@SeanFeldman The unit tests project that needs to get working is Tests.
image

SourceLink.Test is a MSBuild project that will run dotnet sourcelink test.
https://github.com/ctaggart/SourceLink#examples-1

@ctaggart
Copy link
Owner Author

There were some dependency complications before, but try it out and see if it is easier now.

@ctaggart
Copy link
Owner Author

Tests now run, but they need to run each time on AppVeyor too. This is going to stay open until that happens. Failed tests should fail the build and block a merging a pull request.

@ctaggart ctaggart reopened this Sep 12, 2017
@SeanFeldman
Copy link
Contributor

@ctaggart you had tests disabled in AppVeyor configuration.

I've raised a new PR #252 to address it.
Hopefully there will be no other "buts" to get my original PR #240 😉

@chris5287
Copy link
Contributor

@ctaggart this can be closed now?

@ctaggart
Copy link
Owner Author

@chris5287, yes. Thank again @SeanFeldman.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants