This repository was archived by the owner on Apr 16, 2020. It is now read-only.
GitHub url with trailing slash #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctaggart not sure if this will suffice or not. Let me know if there's anything additional that is needed and I've missed. Thank you. |
|
I'd like to get the tests enabled first. This would also apply to the BitBucket one. |
|
I'll look into BitBucket and update it accordingly. |
|
No PR for the tests yet. Also an up for grabs issue. |
|
Must be issue #236 |
|
When you have the unit tests working, Happy to pull this in and publish a minor version like 2.2.1. Going to publish 2.2.0 now without this. Also, I switched back to using a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix to #232