This repository was archived by the owner on Apr 16, 2020. It is now read-only.
GitHub repo url with a trailing slash brakes source linking URLs #232
Comments
|
I can send a PR, but not sure why the tests here are disabled. |
SeanFeldman
added a commit
to SeanFeldman/SourceLink
that referenced
this issue
Aug 15, 2017
SeanFeldman
changed the title
SeanFeldman
added a commit
to SeanFeldman/SourceLink
that referenced
this issue
Aug 22, 2017
SeanFeldman
added a commit
to SeanFeldman/SourceLink
that referenced
this issue
Aug 31, 2017
SeanFeldman
added a commit
to SeanFeldman/SourceLink
that referenced
this issue
Sep 12, 2017
ctaggart
pushed a commit
that referenced
this issue
Sep 13, 2017
* fixes #232 * additional test case * Updated BitBucket URL converter as well * merged rebase conflict * fixing implementations * Today's special: test one one cover another for the same price
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A GitHub repository URL is assumed to have
GitHub also allows repo URL to contain a trailing slash (example:
https://github.com/owners/repo/).When such a url is encountered, SourceLink is generating an incorrect document path having two trailing slashes in front of the commit hash.
Double slash in the repo URL causes HTTP request to fail with 404 error.
Potential fix for this issue would be to ensure repo URL doesn't end with a trailing slash when
UrlConverteris executed, similar to.gitremoval logic.The text was updated successfully, but these errors were encountered: