This repository was archived by the owner on Apr 16, 2020. It is now read-only.
Add support for detecting and writing source link files for submodules #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks @borrrden! I'd like to do a better review then I have time for at the moment. I'm waiting for Visual Studio 15.3 to ship, then there will be a release after that. |
|
I like the idea of supporting this. I'm going to publish 2.2 without it. I'd like to see it added later on when we have better automated tests and someone has time to do a better review. I also decided to switch back to using a |
|
I'm a bit confused by the wording "I'm going let's do." Does that mean you will open the new PR against master or should I? |
|
Please do a new pull request that targets master and hopefully adds some tests once those are up and running #236. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.