Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure imagemagick < 7.0.9 #5

Merged
merged 9 commits into from
Dec 1, 2019
Merged

Make sure imagemagick < 7.0.9 #5

merged 9 commits into from
Dec 1, 2019

Conversation

sebastian-luna-valero
Copy link
Member

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: host: imagemagick < 7.0.9 should not contain a space between relational operator and the version, i.e. imagemagick <7.0.9
  • requirements: run: imagemagick < 7.0.9 should not contain a space between relational operator and the version, i.e. imagemagick <7.0.9

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sebastian-luna-valero
Copy link
Member Author

@conda-forge-admin, please rerender

@sebastian-luna-valero
Copy link
Member Author

@jcupitt

We are facing the same issues here as in #4

  • Linux builds fail with the same error
  • OSX builds fail with the make check (testing blankpage.svg svgload ... save / load difference is 80.000000)

While conda-forge/core takes a look at the Linux issue, could you please upload an equivalent 8.8.1a release, please?

Again, the blankpage.svg svgload failed test should be related to a package update, right? Otherwise, it wouldn't have passed the tests when we released 8.8.1...

@jcupitt
Copy link
Contributor

jcupitt commented Nov 13, 2019

@sebastian-luna-valero OK, I uploaded vips-8.8.1a.tar.gz

Yes, the test failing is because librsvg changed the way they round float pixel coordinates to int.

@sebastian-luna-valero
Copy link
Member Author

Thanks @jcupitt

Do you know by any chance which version librsvg works with the default tests?

Since we are making a new release, I could pin both imagemagick and librsvg for 8.8.1 on this PR.

Or the other way around, do you need to change your tests in libvips to work with the latest librsvg?

@jcupitt
Copy link
Contributor

jcupitt commented Nov 13, 2019

Yes, 8.9 will have a reworked SVG test that's less sensitive to small offsets like this. For now, it's just disabled.

@sebastian-luna-valero sebastian-luna-valero mentioned this pull request Nov 26, 2019
3 tasks
@sebastian-luna-valero
Copy link
Member Author

While we find out what's the issue with gstreamer-orc, we'll pin it for this release of libvips.

@sebastian-luna-valero sebastian-luna-valero merged commit 1a4a676 into master Dec 1, 2019
@sebastian-luna-valero sebastian-luna-valero deleted the 8.8.1-2 branch December 1, 2019 10:56
@hmaarrfk hmaarrfk mentioned this pull request Dec 8, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants