Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version to 8.8.3 #4

Closed
wants to merge 9 commits into from

Conversation

kurtsansom
Copy link

Checklist

updated to version 8.8.3
@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@jcupitt jcupitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you Kurt.

Kurt Sansom and others added 2 commits November 11, 2019 10:03
This is the sha256sum that I get with:
3fe3c323c942172d454983b53606afff62bb472d9038eceb4b583f5dfd04b812
@sebastian-luna-valero
Copy link
Member

Hi, thanks!

Sorry, why is there version 8.3.3 and version 8.3.3a? and which one should we use here?

@jcupitt
Copy link
Contributor

jcupitt commented Nov 11, 2019

Hello, it says in the comment:

vips-8.8.3a.tar.gz is just vips-8.8.3.tar.gz, but with a single test removed to help it pass with a wider range of librsvg versions.

@sebastian-luna-valero
Copy link
Member

Apologies, I took the tarball in a rush and didn't read the comments.

@sebastian-luna-valero
Copy link
Member

Hi,

With version 8.3.3, I get:

testing blankpage.svg svgload ... save / load difference is 80.000000
FAIL test_formats.sh (exit status: 1)

@jcupitt
Copy link
Contributor

jcupitt commented Nov 11, 2019

Yes, that's the test I removed in 8.8.3a, I think.

librsvg changed the way they do coordinate rounding, so all images are displaced by 0.5 pixels. It's enough to break tests that compare against a standard.

@sebastian-luna-valero
Copy link
Member

Thanks, that fixes it.

However, the Linux build is failing randomly with an error that I don't understand:

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... 
ClobberWarning: Conda was asked to clobber an existing path.
  source path: /opt/conda/pkgs/libvips-8.8.3-h49d8aaf_0/lib//
  target path: /home/conda/feedstock_root/build_artifacts/libvips_1573504292703/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib//



done
ERROR:conda.core.link:An error occurred while installing package 'local::libvips-8.8.3-h49d8aaf_0'.
ERROR conda.core.link:_execute(700): An error occurred while installing package 'local::libvips-8.8.3-h49d8aaf_0'.
Rolling back transaction: ...working... done
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 469, in main
    execute(sys.argv[1:])
  File "/opt/conda/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 460, in execute
    verify=args.verify, variants=args.variants)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/api.py", line 209, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 2350, in build_tree
    test(pkg, config=metadata.config.copy(), stats=stats)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 2155, in test
    is_conda=metadata.name() == 'conda')
  File "/opt/conda/lib/python3.7/site-packages/conda_build/environ.py", line 868, in create_env
    execute_actions(actions, index)
  File "/opt/conda/lib/python3.7/site-packages/conda/common/io.py", line 88, in decorated
    return f(*args, **kwds)
  File "/opt/conda/lib/python3.7/site-packages/conda/plan.py", line 321, in execute_actions
    execute_instructions(plan, index, verbose)
  File "/opt/conda/lib/python3.7/site-packages/conda/plan.py", line 533, in execute_instructions
    cmd(state, arg)
  File "/opt/conda/lib/python3.7/site-packages/conda/instructions.py", line 73, in UNLINKLINKTRANSACTION_CMD
    unlink_link_transaction.execute()
  File "/opt/conda/lib/python3.7/site-packages/conda/core/link.py", line 249, in execute
    self._execute(tuple(concat(interleave(itervalues(self.prefix_action_groups)))))
  File "/opt/conda/lib/python3.7/site-packages/conda/core/link.py", line 716, in _execute
    rollback_excs,
conda.CondaMultiError: [Errno 21] Is a directory: '/opt/conda/pkgs/libvips-8.8.3-h49d8aaf_0/lib//'
()

@jcupitt
Copy link
Contributor

jcupitt commented Nov 12, 2019

This error is very suspicious:

conda.CondaMultiError: [Errno 21] Is a 
   directory: '/opt/conda/pkgs/libvips-8.8.3-h49d8aaf_0/lib//'

Why is there a double slash (//) at the end? Perhaps an environment variable has not been set?

@sebastian-luna-valero
Copy link
Member

It looks to me like a conda error, but didn't find a similar problem/solution out there.

I am re-running tests before we ask for help to conda/conda-forge.

@sebastian-luna-valero
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@sebastian-luna-valero
Copy link
Member

xref: conda-forge/pylint-feedstock#27

@sebastian-luna-valero
Copy link
Member

@conda-forge/core please help

@jcupitt
Copy link
Contributor

jcupitt commented Nov 13, 2019

It looks like the current conda package has stopped working too, somehow:

$ conda create --name test python=3 pyvips
...
$ conda activate test
(test) $ which python
/home/john/miniconda3/envs/test/bin/python
(test) $ python
Python 3.7.3 | packaged by conda-forge | (default, Jul  1 2019, 21:52:21) 
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyvips
Segmentation fault (core dumped)

It seems to be failing to dlopen() libgobject, though the library is present in /home/john/miniconda3/envs/test/lib.

@sebastian-luna-valero
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

@sebastian-luna-valero
Copy link
Member

ping @conda-forge/core

@ocefpaf
Copy link
Member

ocefpaf commented Nov 26, 2019

ping @conda-forge/core

Why? Do you need help with something?

@sebastian-luna-valero
Copy link
Member

sebastian-luna-valero commented Nov 26, 2019

Yes, please. We cannot re-render this feedstock.

Please see the error above:

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 26, 2019

Yes, please. We cannot re-render this feedstock.

Did you try following the docs on the bot comment regarding re-rendering it locally?

@sebastian-luna-valero
Copy link
Member

I will try that, thanks.

Are you aware of issues with the conda-forge-webservice ?

@ocefpaf
Copy link
Member

ocefpaf commented Nov 26, 2019

Are you aware of issues with the conda-forge-webservice ?

It is a websevice that may be down due to updates in the pinning package or conda-smithy. That is why the local re-render is always an option.

@sebastian-luna-valero
Copy link
Member

@ocefpaf

We are getting the following error messages:

conda.CondaMultiError: [Errno 21] Is a directory: '/opt/conda/pkgs/libvips-8.8.1-h49d8aaf_1/lib//'

On this PR and on #5

Any suggestions?

@mbargull
Copy link
Member

libtool runs ldconfig and the latter does something funky with the libraries from gstreamer-orc, creating links named '\' and $'\003'.
Interestingly enough, I couldn't reproduce that on my host OS but could -- albeit with the same glibc version -- in a fedora:31 container:

~ >>>  podman run --rm -it centos:6 sh -c 'cd /tmp && curl -sL https://anaconda.org/conda-forge/gstreamer-orc/0.4.31/download/linux-64/gstreamer-orc-0.4.31-h516909a_0.tar.bz2 | tar -xjf- lib/liborc-test-0.4.so.0.31.0 && ldconfig --version | head -n1 && ldconfig -vnN ./lib'
ldconfig (GNU libc) 2.12
./lib:
	\ -> liborc-test-0.4.so.0.31.0 (changed)
~ >>>  podman run --rm -it fedora:31 sh -c 'dnf -qy install bsdtar && cd /tmp && curl -sL https://anaconda.org/conda-forge/gstreamer-orc/0.4.31/download/linux-64/gstreamer-orc-0.4.31-h516909a_0.tar.bz2 | bsdtar -xf- lib/liborc-test-0.4.so.0.31.0 && ldconfig --version | head -n1 && ldconfig -vnN ./lib'
ldconfig (GNU libc) 2.30
./lib:
	\ -> liborc-test-0.4.so.0.31.0 (changed)
~ >>>  podman run --rm -it archlinux/base sh -c 'cd /tmp && curl -sL https://anaconda.org/conda-forge/gstreamer-orc/0.4.31/download/linux-64/gstreamer-orc-0.4.31-h516909a_0.tar.bz2 | bsdtar -xf- lib/liborc-test-0.4.so.0.31.0 && ldconfig --version | head -n1 && ldconfig -vnN ./lib'              
ldconfig (GNU libc) 2.30
./lib:
	liborc-test-0.4.so.0 -> liborc-test-0.4.so.0.31.0 (changed)

@mbargull
Copy link
Member

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@sebastian-luna-valero
Copy link
Member

Closing in favor of #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants