Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recipe Dec 2020 #20

Merged
merged 4 commits into from
Dec 16, 2020

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Dec 8, 2020

Closes #17 #18 #19

Apparently an updated version fixes compilation errors
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971106

Many image processing librarires have already migrated to newer hdf5. I had to force the migration myself to install this package in conjunction with my other ones.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

it seems many pinnings were due to some unknown issues with particular versions of the library:

#5

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

@conda-forge/help-c-cpp does anybody know why the following error is appearing:

dyld: Library not loaded: @rpath/libgobject-2.0.0.dylib
  Referenced from: /Users/runner/miniforge3/conda-bld/libvips_1607387342067/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/libMagickCore-7.Q16HDRI.7.dylib
  Reason: Incompatible library version: libMagickCore-7.Q16HDRI.7.dylib requires version 6501.0.0 or later, but libgobject-2.0.0.dylib provides version 0.0.0

@hmaarrfk hmaarrfk changed the title Libtiff 4.1 update recipe Dec 2020 Dec 8, 2020
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

@hmaarrfk hmaarrfk mentioned this pull request Dec 8, 2020
5 tasks
@hmaarrfk hmaarrfk changed the title update recipe Dec 2020 [WIP] update recipe Dec 2020 Dec 8, 2020
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

@conda-forge/help-osx-arm64 (ok, i know this isn't arm, but I figure you know the most about Apple).

How do we feel about moving the OSX pinning up to 10.10. 10.9 is becoming increasingly harder to support for graphical applications.

@xhochy
Copy link
Member

xhochy commented Dec 8, 2020

@hmaarrfk Not sure why you have bumped glib to a much higher version than the pinning here. Keeping it at 2.58 would avoid the OSX update.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

@xhochy thanks for chiming in.

Please see the build logs of 467e687 and the error reported in:
#20 (comment)

tschoonj suggested applying the migration. conda-forge/glib-feedstock#77 (comment)

Lets see what happens.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

@hmaarrfk hmaarrfk changed the title [WIP] update recipe Dec 2020 update recipe Dec 2020 Dec 8, 2020
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2020

thanks everybody. this is ready to go now.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 9, 2020

@conda-forge/libvips i've added myself as a maintainer to help along if that is ok.

Let me know if there is antyhing else i can change.

@hmaarrfk hmaarrfk mentioned this pull request Dec 9, 2020
5 tasks
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

@conda-forge/libvips a review would be greatly appreciated. The previous pinnings stop this package from getting installed smoothly with recent migrations.

@sebastian-luna-valero
Copy link
Member

Hi @hmaarrfk

Many thanks for your contribution!

I am happy with the changes and having you on board as a recipe maintainer would be great.

Can I just double check whether @jcupitt is happy before merging?

Best regards,
Sebastian

@hmaarrfk
Copy link
Contributor Author

Thanks @sebastian-luna-valero

@sebastian-luna-valero sebastian-luna-valero merged commit 8e61b30 into conda-forge:master Dec 16, 2020
@sebastian-luna-valero
Copy link
Member

Welcome @hmaarrfk !

@jcupitt
Copy link
Contributor

jcupitt commented Dec 16, 2020

Sure, I'm more than happy. Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants