[CPP20][ALCA] Replace some enums with constexpr ints

[iarspider]

PR description:

Replace some enums with constexpr ints to avoid deprecated enum arithmetics. Replaces #44485 following @makortel's suggestion.

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44509/39628

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibFormats/SiStripObjects/interface/SiStripRegionCabling.h modified in PR(s): [CPP20][ALCA, DB] Remove deprecated enum arithmetic #44485

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Alignment/Geners (alca)
• CalibFormats/SiStripObjects (alca)

@perrotta, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks.
@tocheng, @rsreds, @mmusich, @adewit, @threus, @yuanchao this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-700ca2/38341/summary.html
COMMIT: 1185533
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @valsdav DeepTau - Do not call TF inference with empty grid #44455
• @Dr15Jones Use default operator= in CondFormats/CSCObjects #44462
• @mmusich add a python compilation unit test for DQM online clients #44412
• @fwyzard Improve error handling in GPU callbacks #44476
• @fwyzard Improve the memory usage in the alpaka pixel reconstruction #44458
• @vlimant adding JME nano in autoNano #44087
• @mmusich TkAl: fix PV validation and PV resolution submission scripts #44467
• @Dr15Jones Apply rule-of-5 to ESPreFunctorDecorator #44483
• @Dr15Jones Removed explicit copy ctr in TrackStub #44482
• @valsdav Improve handling of TF CUDA tests for 14_1_X #44376
• @aehart KalmanFilter fix for Phase 2 L1 tracking #44427
• @smuzaffar Remove unused strstream to fix the deprecated header warning #44426
• @swagata87 Produce r9 and trackIso(hollow cone) in EGamma development path #44423
• @stahlleiton Add use of unsubtracted jets in RecoBTag info producers #44422
• @watson-ij Allow storing 2024 geometry in GEMGeometryParsFromDD #44429
• @makortel Fix plugin library name AlpakaCore/plugins/BuildFile.xml #44445
• @Dr15Jones Use standard file names in DQM/HcalTasks config files #44408
• @saumyaphor4252 Add GEM channel and strip payload dump utilities #44460
• @fwyzard Fix track sort order in PixelTrackProducerFromSoAAlpaka #44441
• @mmusich reverts #44054 and #44389 #44466
• @kyungminparkdrums Change FEStatus flag labels in ECAL DQM #44402
• @abdoulline HCAL proprietary RelVal machinery update #43953
• @Dr15Jones Use standard naming for configs in CondTools/RunInfo #44407
• @iarspider [AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448
• @iarspider [CPP20][RECONSTRUCTION] Remove deprecated enum arithmetic #44490
• @iarspider [CPP20][Analysis] Remove deprecated enum arithmetic #44486
• @germanfgv Add NanoAOD flavours parameter to PromptReco #44430
• @hsinweihsia modified for Phase2 DeepJet retraining model #44431
• @bachtis Updated quality bits of KMTF  #44432
• @mmusich MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434
• @fwyzard Update the HLT alpaka customisation #44439

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-700ca2/38341/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-700ca2/38341/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testRecoBTagInfoWithUnsubJets had ERRORS

RelVals

• 24896.0

----- Begin Fatal Exception 22-Mar-2024 15:25:14 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24896.0_CloseByPGun_CE_E_Front_120um+2026D98


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

• 24900.0

----- Begin Fatal Exception 22-Mar-2024 15:26:00 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24900.0_CloseByPGun_CE_H_Coarse_Scint+2026D98


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

• 24834.0

----- Begin Fatal Exception 22-Mar-2024 15:28:38 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44509/38341/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24834.0_TTbar_14TeV+2026D98


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 24834.911
• 25034.999

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-700ca2/38428/summary.html
COMMIT: 1185533
CMSSW: CMSSW_14_1_CPP20_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44509/38428/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2449 lines to the logs
• Reco comparison results: 138 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 1857
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3295660
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

I am pretty sure that the several differences in tracking quantities are due to the different architecture CMSSW_14_1_CPP20_X in which this PR (and the previous #44485) is built. However, before signing let me satisfy my curiosity and retest with the same compiler as used for the references.

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-700ca2/38443/summary.html
COMMIT: 1185533
CMSSW: CMSSW_14_1_X_2024-03-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44509/38443/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially removed 102 lines from the logs
• Reco comparison results: 59 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297857
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297825
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

• Unit test error is unrelated
• Comparisons using the same compiler do not show differences in tracking quantities any more

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

ignore tests-rejected with external-failure

[antoniovilela]

+1