Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard naming for configs in CondTools/RunInfo #44407

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Use standard naming for configs in CondTools/RunInfo #44407

merged 1 commit into from
Mar 20, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Added _cfg.py to configuration file names
This avoids conflicts with auto generated files coming from fillDescriptions.

PR validation:

Can not full run unit tests as the machine I worked on did not have access to oracle DB.

@Dr15Jones
Use standard naming for configs in CondTools/RunInfo
3558534 
Added _cfg.py to configuration file names
This avoids conflicts with auto generated files coming from
fillDescriptions.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 14, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44407/39480

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • CondCore/Utilities (db)
  • CondTools/RunInfo (db)

@perrotta, @consuegs, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@rsreds, @mmusich, @yuanchao, @PonIlya this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@Dr15Jones
Copy link
Contributor Author

An additional improvement would by to move these files out of the python directory as they are never meant to be imported to python. Could go into a config directory instead.

@makortel makortel mentioned this pull request Mar 14, 2024
Closed
@francescobrivio
Copy link
Contributor

Hi Chris,
I only had time to have a very quick look at this PR for now, but some of the renamed pythons in RunInfo are the actual scripts executed in the LHCInfo O2Os.

This is the master branch so it's not a big deal for operations at the moment, but it will be once we'll move to newer releases (i.e. we'll have to remember to change the script names in the appropriate machines).
We'll take a better look tomorrow and provide feedback!

FYI @JanChyczynski

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e82bfe/38143/summary.html
COMMIT: 3558534
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44407/38143/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 25034.11425034.114_TTbar_14TeV+2026D98PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D98PU_OTInefficiency10PC.log

Comparison Summary

The workflows 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 60 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 1355
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3296008
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@francescobrivio
Copy link
Contributor

Hi Chris, I only had time to have a very quick look at this PR for now, but some of the renamed pythons in RunInfo are the actual scripts executed in the LHCInfo O2Os.

This is the master branch so it's not a big deal for operations at the moment, but it will be once we'll move to newer releases (i.e. we'll have to remember to change the script names in the appropriate machines). We'll take a better look tomorrow and provide feedback!

FYI @JanChyczynski

@Dr15Jones
Hi Chris,
Sorry for the delay! I went through the full list of updated configs and I see 3 cases:

  • RunInfo config --> this is especially important for the RunInfo Start/End run O2Os, if this breaks then cDAQ won't be able to start a new run!
  • Old LHCInfo configs --> soon to be retired from production
  • New LHCInfoPer* configs --> being deployed in production these days

So I don't see any issue with this PR per-se as long as:

  1. We don't backport it to 14_0_X (is this foreseen?)
  2. We (@cms-sw/alca-l2 @cms-sw/db-l2 @JanChyczynski) remember to update all the O2O scripts once we switch to CMSSW >= 14_1_X in production!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e82bfe/38254/summary.html
COMMIT: 3558534
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44407/38254/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@francescobrivio
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

Hi Chris, I only had time to have a very quick look at this PR for now, but some of the renamed pythons in RunInfo are the actual scripts executed in the LHCInfo O2Os.
This is the master branch so it's not a big deal for operations at the moment, but it will be once we'll move to newer releases (i.e. we'll have to remember to change the script names in the appropriate machines). We'll take a better look tomorrow and provide feedback!
FYI @JanChyczynski

@Dr15Jones Hi Chris, Sorry for the delay! I went through the full list of updated configs and I see 3 cases:

  • RunInfo config --> this is especially important for the RunInfo Start/End run O2Os, if this breaks then cDAQ won't be able to start a new run!
  • Old LHCInfo configs --> soon to be retired from production
  • New LHCInfoPer* configs --> being deployed in production these days

So I don't see any issue with this PR per-se as long as:

  1. We don't backport it to 14_0_X (is this foreseen?)
  2. We (@cms-sw/alca-l2 @cms-sw/db-l2 @JanChyczynski) remember to update all the O2O scripts once we switch to CMSSW >= 14_1_X in production!

@francescobrivio @JanChyczynski
In which repository are the O2O scripts maintained? It would be good to open an issue there, so that you remember to make this update.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ed4af7 into cms-sw:master Mar 20, 2024
11 checks passed
@francescobrivio
Copy link
Contributor

@francescobrivio @JanChyczynski
In which repository are the O2O scripts maintained? It would be good to open an issue there, so that you remember to make this update.

Dear @antoniovilela, many thanks for the nice suggestion!
Here are the issues:

This was referenced Mar 22, 2024
Merged
Merged
@Dr15Jones Dr15Jones deleted the fixNamesCondToolsRunInfo branch March 26, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @francescobrivio @antoniovilela