Produce r9 and trackIso(hollow cone) in EGamma development path

[swagata87]

PR description:

We would like to explore the potential of the variables r9 and track isolation (hollow cone) in the context of phase2 photon paths. The photon paths in Run2/Run3 use these variables, but we haven't yet explored them for phase2. This PR adds these two variables in the development path, and thus makes it easier to study these variables. Once properly studied and cuts are decided, they can be added in real HLT paths as producer+filter.

PR validation:

Phase2 HLT runs fine, and the distribution of new variables look reasonable.
Left plot: r9, Right plot: track iso (hollow cone)

[swagata87]

type egamma

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44423/39495

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@mmusich, @Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@SohamBhattacharya, @silviodonato, @missirol, @Martin-Grunewald, @rovere this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70955d/38167/summary.html
COMMIT: cca7d58
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44423/38167/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297357
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[SohamBhattacharya]

This looks fine for hlt-upgrade. The changes affect only the dev paths and not the menu, and the new variable distributions are reasonable, as already pointed out by Swagata.

[Martin-Grunewald]

Should there be a backport to 14_0?

[mmusich]

The changes affect only the dev paths and not the menu,

if that's the case why do we see changes in trigger results: TriggerResults ?
Aren't these:

     Events    Accepted      Gained        Lost       Other  Trigger
          10           0           -           -         ~10  MC_Ele5_Open_Unseeded
          10           0           -           -         ~10  MC_Ele5_Open_L1Seeded

part of the menu?

[SohamBhattacharya]

Should there be a backport to 14_0?

@swagata87 Yes please.

The changes affect only the dev paths and not the menu,

if that's the case why do we see changes in trigger results: TriggerResults ? Aren't these:

     Events    Accepted      Gained        Lost       Other  Trigger
          10           0           -           -         ~10  MC_Ele5_Open_Unseeded
          10           0           -           -         ~10  MC_Ele5_Open_L1Seeded

part of the menu?

The Open paths are the dev paths -- it's run in the menu here for testing/debugging, but not a part of the "realistic" menu -- for e.g. the one used for timing measurements.
That's what I'd meant. Sorry for the confusion.

[mmusich]

Should there be a backport to 14_0?

does this need the changes in #44025 as well?

[mmusich]

+hlt

• see Produce r9 and trackIso(hollow cone) in EGamma development path #44423 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44423/39522

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #44423 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70955d/38224/summary.html
COMMIT: 4708629
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44423/38224/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 28 lines from the logs
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297343
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[swagata87]

backport : #44452

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1