fix use after scope in DMRChecker::bookResidualsHistogram

[mmusich]

resolves #37765

PR description:

Title says is all, fix for #37765

PR validation:

cmssw compiles, run successfully unit tests of package Alignment/OfflineValidation with these changes inCMSSW_12_4_ASAN_X_2022-05-02-1100.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[mmusich]

test parameters:

• release = CMSSW_12_4_ASAN_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37796/29705

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[tvami]

type trk

[mmusich]

the affected unit test comes out actually fine: log.
The other failures are unrelated:

• testSiStripHitEfficiency => [ASAN_X] Test CalibTracker/SiStripHitEfficiency fails with SIGSEGV #37781
• DRNTest => Triton fallback server failure in workflow 10805.31 step 3 #37767

@tvami shall we stop here and re-test with the standard build?

[tvami]

@tvami shall we stop here and re-test with the standard build?

We can just trigger the standard test on the top of this, not necessary to kill this

[mmusich]

We can just trigger the standard test on the top of this, not necessary to kill this

It will show the failure in the bottom check box, which is misleading.

[tvami]

@cmsbuild , please test for CMSSW_12_4_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-288732/24438/summary.html
COMMIT: e539b44
CMSSW: CMSSW_12_4_ASAN_X_2022-05-02-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37796/24438/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @radla118 Modifying the AlcaPCCIntegrator for processing concurrent lumiblocks #37538
• @kpedro88 Puppi speedup: use reserve for vectors #37717
• @smuzaffar SHA1 Hash: use correct length to terminate the string instead of hardcoded value #37774
• @drkovalskyi added NanoAOD to PromptReco #37728
• @fwyzard Update the .gitignore rules #37719
• @bsunanda Run3-sim118A Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation #37752
• @Dr15Jones Changed CSCRecoBadChannelsAnalyzer to be a one::EDAnalyzer #37751
• @Dr15Jones Fixed deprecation warnings in RecoLocalMuon/CSCSegment #37750
• @bsunanda Run3-sim118B Try to replace getByLabel with token in SimCalorimetry/CastorSim #37757
• @smuzaffar Remove deprecated Openssl functions SHA1* #37770
• @cms-tsg-storm HLT menu development for 12_3_X [12_4_X] #37754
• @Dr15Jones Added IOV synchronization callbacks to ActivityRegistry #37771
• @bsunanda Phase2-hgx310C Add in line documentation to some service methods in Geometry/HGCalCommonData #37759
• @AdrianoDee GPUvsCPU: updates to modules and workflows for pixel reconstruction #37617
• @stahlleiton Link slimmed muons to lost tracks #37596
• @eyigitba Correct input collections to the TF emulators for Run 3 MC re-emulation #37703
• @Dr15Jones Add more context to Vertex exceptions #37766
• @Dr15Jones Added TritonService to exception messages #37764
• @dsperka Optimizations to the Scouting Data Formats #37646
• @Dr15Jones Fixed deprecation warnings in CSCEfficiency #37748
• @mseidel42 Set Rivet paths with setenv instead of putenv #37761
• @Michael-Krohn modify HCAL output LUT for saturated TPs with |ieta|>=21 #37745
• @Dr15Jones Fixed CMS deprecation warnings in CommonTools/ParticleFlow #37746
• @smuzaffar EL9 warning fix: use mallinfo2 for glibc>=2.33 #37768
• @esiam JME DQM updates for Run3 (12_4_X) #37725

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-288732/24438/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-288732/24438/git-merge-result

CMS deprecated warnings: 39 CMS deprecated warnings found, see summary page for details.

Unit Tests

I found errors in the following unit tests:

---> test testSiStripHitEfficiency had ERRORS
---> test DRNTest had ERRORS

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-288732/24449/summary.html
COMMIT: e539b44
CMSSW: CMSSW_12_4_X_2022-05-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37796/24449/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
39434.501 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700518
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass
• unit test reported in Use after scope in DMRChecker::bookResidualsHistogram #37765 is passing in ASAN, other issues are understood
• standard CMSSW diffs are known as well

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1