EL9 warning fix: use mallinfo2 for glibc>=2.33

[smuzaffar]

mallinfo has been deprecated in newer glibc version e.g. for el9 IBs we get build warning [a]. glibc 2.33 and above introduced mallinfo2 which returns the same mallinfo2 struct but with updated types size_t instead of int (https://man7.org/linux/man-pages/man3/mallinfo.3.html) . This PR proposes to use mallinfo2 for glibc version 2.33 and above.

In a separate PR we can also replace i2str with std::to_string()

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el9_amd64_gcc11/CMSSW_12_4_X_2022-05-01-2300/FWCore/Services

  src/FWCore/Services/plugins/SimpleMemoryCheck.cc:551:39: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
   551 |       struct mallinfo minfo = mallinfo();

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37768/29656

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• FWCore/Services (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test for el9_amd64_gcc11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6dc13/24390/summary.html
COMMIT: 952022f
CMSSW: CMSSW_12_4_X_2022-05-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37768/24390/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3703092
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3703062
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6dc13/24391/summary.html
COMMIT: 952022f
CMSSW: CMSSW_12_4_X_2022-05-01-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37768/24391/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar EL9: Fix OpenSSL warnings #37629
• @makortel Remove some unnecessary framework includes from ReggeGribovPartonMCHadronizer #37710

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6dc13/24391/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6dc13/24391/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_conddb had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 69704 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3703092
• DQMHistoTests: Total failures: 475300
• DQMHistoTests: Total nulls: 348
• DQMHistoTests: Total successes: 3227422
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6440000000000001 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
• Checked 205 log files, 45 edm output root files, 49 DQM output files

[smuzaffar]

please test for el9_amd64_gcc11

[smuzaffar]

@makortel , any objections on this change? This should fix the last remaining warnings for EL9 arch

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6dc13/24401/summary.html
COMMIT: 952022f
CMSSW: CMSSW_12_4_X_2022-05-02-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37768/24401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 69699 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 607316
• DQMHistoTests: Total nulls: 347
• DQMHistoTests: Total successes: 3092863
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6480000000000001 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
• Checked 205 log files, 45 edm output root files, 49 DQM output files