Run3-sim118A Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation #37752

bsunanda · 2022-04-30T01:55:43Z

PR description:

Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

…sEmulation

cmsbuild · 2022-04-30T02:01:11Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37752/29621

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37752/29621/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37752/29621/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-04-30T02:08:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37752/29622

This PR adds an extra 20KB to repository

cmsbuild · 2022-04-30T02:08:55Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimCalorimetry/EcalElectronicsEmulation (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @rovere, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-05-01T01:37:54Z

@cmsbuild Please test

cmsbuild · 2022-05-01T15:50:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e8ee4/24361/summary.html
COMMIT: 122d884
CMSSW: CMSSW_12_4_X_2022-05-01-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37752/24361/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3704146
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3704110
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

civanch · 2022-05-02T11:26:40Z

SimCalorimetry/EcalElectronicsEmulation/src/EcalSimRawData.cc

@@ -166,7 +166,9 @@ string EcalSimRawData::getExt() const {
  }
 }

-void EcalSimRawData::genFeData(string basename, int iEvent, const vector<uint16_t> adcCount[nEbEta][nEbPhi]) const {
+void EcalSimRawData::genFeData(std::string basename,


@bsunanda , why not std::string& ?

civanch · 2022-05-02T11:28:51Z

SimCalorimetry/EcalElectronicsEmulation/src/EcalSimRawData.cc

-         << " Event " << iEvent << "\n"
-         << "------------------------------------------------------------------"
-            "----\n";
+    std::cout << "=================================================================="


@bsunanda , why std::cout and no end of line? I mean "/n" as a last symbol not always complete the line.

cmsbuild · 2022-05-02T14:11:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37752/29655

This PR adds an extra 24KB to repository

cmsbuild · 2022-05-02T14:11:44Z

Pull request #37752 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

bsunanda · 2022-05-02T14:12:53Z

@cmsbuild Please test

cmsbuild · 2022-05-02T18:16:29Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e8ee4/24388/summary.html
COMMIT: 09ee364
CMSSW: CMSSW_12_4_X_2022-05-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37752/24388/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3703092
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3703056
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

civanch · 2022-05-03T08:14:09Z

+1

cmsbuild · 2022-05-03T08:14:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-03T09:51:56Z

SimCalorimetry/EcalElectronicsEmulation/src/EcalSimRawData.cc

-               << "0x" << setw(4) << tcp[iTtEta0][iTtPhi0] << "\tcmssw indices: " << tp.id().ieta() << " "
-               << tp.id().iphi() << "\n";
+        if (tcp[iTtEta0][iTtPhi0] != 0) {  // print non-zero values only
+          std::string collName = (type == 0) ? tcpDigiCollection_ : tpDigiCollection_;


Suggested change

std::string collName = (type == 0) ? tcpDigiCollection_ : tpDigiCollection_;

std::string collName = (type == EcalSimRawData::tcp) ? tcpDigiCollection_ : tpDigiCollection_;

(Very minor point, not worth preventing this to get merged, but perhaps you'll like to take it into account in further cleanups)

perrotta · 2022-05-03T09:52:11Z

+1

perrotta · 2022-05-03T12:24:07Z

merge

Try to replace getByLabel with token in SimCalorimetry/EcalElectronic…

c571709

…sEmulation

cmsbuild added this to the CMSSW_12_4_X milestone Apr 30, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 30, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 30, 2022

Code check

122d884

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 30, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2022

cmsbuild added tests-started and removed tests-pending labels May 1, 2022

cmsbuild added tests-approved and removed tests-started labels May 1, 2022

civanch reviewed May 2, 2022

View reviewed changes

Take comments from Vladimir

bd88c49

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels May 2, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 2, 2022

Code check

09ee364

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 2, 2022

cmsbuild added tests-started and removed tests-pending labels May 2, 2022

cmsbuild added tests-approved and removed tests-started labels May 2, 2022

cmsbuild removed the simulation-pending label May 3, 2022

cmsbuild added fully-signed simulation-approved and removed pending-signatures labels May 3, 2022

perrotta reviewed May 3, 2022

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels May 3, 2022

cmsbuild merged commit 64d8bbe into cms-sw:master May 3, 2022

This was referenced May 4, 2022

Update vecgeom to 1.1.20 cms-sw/cmsdist#7735

Merged

fix use after scope in DMRChecker::bookResidualsHistogram #37796

Merged

bsunanda deleted the Run3-sim118A branch August 20, 2022 04:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-sim118A Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation #37752

Run3-sim118A Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation #37752

bsunanda commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

bsunanda commented May 1, 2022

cmsbuild commented May 1, 2022

civanch May 2, 2022

civanch May 2, 2022

cmsbuild commented May 2, 2022

cmsbuild commented May 2, 2022

bsunanda commented May 2, 2022

cmsbuild commented May 2, 2022

civanch commented May 3, 2022

cmsbuild commented May 3, 2022

perrotta May 3, 2022

perrotta commented May 3, 2022

perrotta commented May 3, 2022

	std::string collName = (type == 0) ? tcpDigiCollection_ : tpDigiCollection_;
	std::string collName = (type == EcalSimRawData::tcp) ? tcpDigiCollection_ : tpDigiCollection_;

Run3-sim118A Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation #37752

Run3-sim118A Try to replace getByLabel with token in SimCalorimetry/EcalElectronicsEmulation #37752

Conversation

bsunanda commented Apr 30, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

bsunanda commented May 1, 2022

cmsbuild commented May 1, 2022

Comparison Summary

civanch May 2, 2022

Choose a reason for hiding this comment

civanch May 2, 2022

Choose a reason for hiding this comment

cmsbuild commented May 2, 2022

cmsbuild commented May 2, 2022

bsunanda commented May 2, 2022

cmsbuild commented May 2, 2022

Comparison Summary

civanch commented May 3, 2022

cmsbuild commented May 3, 2022

perrotta May 3, 2022

Choose a reason for hiding this comment

perrotta commented May 3, 2022

perrotta commented May 3, 2022