Remove unneeded dependencies from plugins, test and bin in Reco subsystems

[guitargeek]

PR description:

Another quick round of automatic BuildFile.xml cleaning to improve the modularity of CMSSW.

After #29053 finished cleaning the BuildFiles in the libraries, this PR now covers all the other subdirectories like bin, plugins and test. This is a bit easier because no other build targets depend of these.

Little particularity: the Geometry/CaloEventSetup library had no BuildFile before because it was headers only, but now I added a BuildFile.xml to specify the dependencies of these header files, so they are correctly propagated. Otherwise, the build targets that require Geometry/CaloEventSetup have to make the corresponding use statements even if they don't use the libraries themselves. Furthermore, a few includes that were clearly out of place were removed.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29295/14357

• This PR adds an extra 188KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Calibration/TkAlCaRecoProducers/plugins/BuildFile.xml modified in PR(s): [DO NOT MERGE] Fake change to BuildFile.xml to trigger compilation in cms-bot for LogDebug issue #29272
  • File RecoBTag/ONNXRuntime/plugins/BuildFile.xml modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
  • File RecoBTag/TensorFlow/plugins/BuildFile.xml modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
  • File RecoLocalCalo/EcalRecProducers/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelClusterizer/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelRecHits/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelTrackFitting/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelTriplets/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelVertexFinding/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoVertex/BeamSpotProducer/plugins/BuildFile.xml modified in PR(s): Patatrack integration - add module for transferring the beam spot to the GPU (3/N) #29154, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29295/14357/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29295/14357/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29295/14360

• This PR adds an extra 188KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Calibration/TkAlCaRecoProducers/plugins/BuildFile.xml modified in PR(s): [DO NOT MERGE] Fake change to BuildFile.xml to trigger compilation in cms-bot for LogDebug issue #29272
  • File RecoBTag/ONNXRuntime/plugins/BuildFile.xml modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
  • File RecoBTag/TensorFlow/plugins/BuildFile.xml modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
  • File RecoLocalCalo/EcalRecProducers/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelClusterizer/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelRecHits/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelTrackFitting/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelTriplets/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelVertexFinding/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoVertex/BeamSpotProducer/plugins/BuildFile.xml modified in PR(s): Patatrack integration - add module for transferring the beam spot to the GPU (3/N) #29154, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
Calibration/HcalAlCaRecoProducers
Calibration/LumiAlCaRecoProducers
Calibration/TkAlCaRecoProducers
CommonTools/ParticleFlow
CommonTools/RecoUtils
CondCore/AlignmentPlugins
DataFormats/MuonReco
DataFormats/VertexReco
Geometry/CaloEventSetup
PhysicsTools/IsolationAlgos
PhysicsTools/PatAlgos
RecoBTag/Combined
RecoBTag/FeatureTools
RecoBTag/ImpactParameter
RecoBTag/MXNet
RecoBTag/ONNXRuntime
RecoBTag/PerformanceDB
RecoBTag/SoftLepton
RecoBTag/TensorFlow
RecoBTag/TrackProbability
RecoCaloTools/Navigation
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaHFProducers
RecoEgamma/ElectronIdentification
RecoEgamma/Examples
RecoEgamma/PhotonIdentification
RecoHGCal/TICL
RecoHI/HiJetAlgos
RecoHI/HiMuonAlgos
RecoHI/HiTracking
RecoJets/JetProducers
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HGCalRecProducers
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoLocalFastTime/FTLClusterizer
RecoLocalFastTime/FTLCommonAlgos
RecoLocalFastTime/FTLRecProducers
RecoLocalMuon/CSCSegment
RecoLocalMuon/DTRecHit
RecoLocalMuon/DTSegment
RecoLocalMuon/GEMCSCSegment
RecoLocalMuon/GEMRecHit
RecoLocalMuon/GEMSegment
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/SiPhase2Clusterizer
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripRecHitConverter
RecoMTD/Navigation
RecoMuon/CosmicMuonProducer
RecoMuon/GlobalMuonProducer
RecoMuon/GlobalTrackingTools
RecoMuon/L2MuonIsolationProducer
RecoMuon/L3MuonIsolationProducer
RecoMuon/MuonIdentification
RecoMuon/MuonIsolationProducers
RecoMuon/Navigation
RecoMuon/StandAloneMuonProducer
RecoMuon/TrackingTools
RecoPPS/Local
RecoParticleFlow/PFClusterTools
RecoParticleFlow/PFTracking
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelTriplets
RecoPixelVertexing/PixelVertexFinding
RecoTBCalo/HcalTBObjectUnpacker
RecoTauTag/ImpactParameter
RecoTracker/ConversionSeedGenerators
RecoTracker/DebugTools
RecoTracker/FinalTrackSelectors
RecoTracker/GeometryESProducer
RecoTracker/NuclearSeedGenerator
RecoTracker/TkHitPairs
RecoTracker/TkMSParametrization
RecoTracker/TkNavigation
RecoTracker/TkSeedGenerator
RecoTracker/TkSeedingLayers
RecoTracker/TrackProducer
RecoTracker/TransientTrackingRecHit
RecoVertex/AdaptiveVertexFinder
RecoVertex/BeamSpotProducer
RecoVertex/GaussianSumVertexFit
RecoVertex/KalmanVertexFit
RecoVertex/KinematicFit
RecoVertex/PrimaryVertexProducer
RecoVertex/V0Producer
SimGeneral/PileupInformation
TrackingTools/RecoGeometry
Validation/RecoB
Validation/RecoEgamma
Validation/RecoHI
Validation/RecoJets
Validation/RecoMET
Validation/RecoMuon
Validation/RecoPixelVertexing
Validation/RecoTau
Validation/RecoTrack

@andrius-k, @schneiml, @ianna, @kpedro88, @Martin-Grunewald, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @fwyzard, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @kmaeshima, @christopheralanwest, @franzoni can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @yslai, @felicepantaleo, @jainshilpi, @wmtford, @robervalwalsh, @emilbols, @apsallid, @mandrenguyen, @jshlee, @mschrode, @pfs, @abbiendi, @peruzzim, @seemasharmafnal, @sobhatta, @mmarionncern, @sethzenz, @JyothsnaKomaragiri, @makortel, @smoortga, @afiqaize, @mverzett, @jhgoh, @lgray, @jdolen, @dkotlins, @ebrondol, @cericeci, @amagitte, @threus, @ptcox, @ferencek, @pieterdavid, @yetkinyilmaz, @jazzitup, @vandreev11, @Sam-Harper, @hqucms, @kkrajczar, @cbernet, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @bellan, @nhanvtran, @gkasieczka, @tocheng, @deguio, @schoef, @alesaggio, @echapon, @mmusich, @argiro, @mtosi, @dgulhan, @clelange, @jdamgov, @calderona, @HuguesBrun, @trocino, @riga, @battibass, @varuns23, @miheejo, @Fedespring, @edjtscott, @ahinzmann, @hatakeyamak, @yenjie, @rylanC24, @folguera, @lecriste, @kurtejung, @gpetruc, @gbenelli, @mariadalfonso, @rociovilar, @andrzejnovak, @bachtis, @yduhm this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5370/console Started: 2020/03/25 12:30