Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies from plugins, test and bin in Reco subsystems #29295

Merged
merged 1 commit into from
Apr 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Calibration/EcalAlCaRecoProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<use name="FWCore/ParameterSet"/>
<use name="clhep"/>
<use name="Geometry/CaloTopology"/>
<use name="Geometry/EcalAlgo"/>
<use name="Geometry/HcalTowerAlgo"/>
<use name="Geometry/Records"/>
<use name="DataFormats/TrackReco"/>
Expand All @@ -16,6 +17,5 @@
<use name="CalibFormats/HcalObjects"/>
<use name="Geometry/EcalMapping"/>
<use name="Geometry/CaloGeometry"/>
<use name="RecoEcal/EgammaCoreTools"/>
<use name="CalibTracker/Records"/>
<flags EDM_PLUGIN="1"/>
1 change: 0 additions & 1 deletion Calibration/HcalAlCaRecoProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<use name="FWCore/ParameterSet"/>
<use name="HLTrigger/HLTcore"/>
<use name="Calibration/IsolatedParticles"/>
<use name="DataFormats/EgammaReco"/>
<use name="DataFormats/JetReco"/>
<use name="rootphysics"/>
<library file="*.cc" name="CalibrationHcalAlCaRecoProducersPlugins">
Expand Down
4 changes: 0 additions & 4 deletions Calibration/LumiAlCaRecoProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,11 @@
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DQMServices/Core"/>
<use name="DQMServices/Components"/>

<use name="CondCore/Utilities"/>
<use name="FWCore/ServiceRegistry"/>
<use name="FWCore/PluginManager"/>
<use name="CondFormats/Luminosity"/>
<use name="CoralBase"/>
<use name="CondCore/DBOutputService"/>
<use name="CondCore/ESSources"/>

<use name="DataFormats/Luminosity"/>
<use name="CondFormats/DataRecord"/>
Expand Down
1 change: 0 additions & 1 deletion Calibration/TkAlCaRecoProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

<use name="CondCore/Utilities"/>
<use name="FWCore/ServiceRegistry"/>
<use name="FWCore/PluginManager"/>
<use name="CondFormats/BeamSpotObjects"/>
<use name="CondFormats/DataRecord"/>
<use name="CondCore/DBOutputService"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#include "PFCandWithSuperClusterExtractor.h"

#include "RecoMuon/MuonIsolation/interface/Range.h"
#include "DataFormats/RecoCandidate/interface/IsoDepositDirection.h"
#include "DataFormats/Common/interface/Handle.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
Expand Down
17 changes: 0 additions & 17 deletions CommonTools/RecoUtils/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,27 +1,10 @@
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/ServiceRegistry"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CommonTools/RecoUtils"/>
<use name="DataFormats/BeamSpot"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/ParticleFlowReco"/>
#<use name="DQMServices/Core"/>
<use name="MagneticField/Records"/>
<use name="MagneticField/Engine"/>
<use name="SimDataFormats/TrackingAnalysis"/>
#<use name="SimDataFormats/PileupSummaryInfo"/>
<use name="SimDataFormats/GeneratorProducts"/>
<use name="SimTracker/TrackAssociation"/>
#<use name="SimTracker/Records"/>
<use name="TrackingTools/TransientTrack"/>
<use name="TrackingTools/IPTools"/>
<library file="*.cc" name="PFPUAssoMapPlugins">
<flags EDM_PLUGIN="1"/>
</library>
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "DataFormats/SiStripDetId/interface/StripSubdetector.h"
#include "DataFormats/DetId/interface/DetId.h"

#include "Alignment/CommonAlignment/interface/Utilities.h"
#include "CondFormats/Alignment/interface/Definitions.h"

// needed for the tracker map
#include "CommonTools/TrackerMap/interface/TrackerMap.h"
Expand Down
1 change: 0 additions & 1 deletion DataFormats/MuonReco/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<use name="DataFormats/MuonReco"/>
<bin name="testDataFormatsMuonReco" file="testMuon.cc,testRunner.cpp">
<use name="cppunit"/>
</bin>
5 changes: 0 additions & 5 deletions DataFormats/VertexReco/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
<use name="FWCore/Utilities"/>
<use name="FWCore/Framework"/>
<use name="DataFormats/TrackReco"/>
<use name="clhep"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/VertexReco"/>
<use name="root"/>
<bin name="testDataFormatsVertexReco" file="testVertex.cc,testRunner.cpp">
Expand Down
3 changes: 3 additions & 0 deletions Geometry/CaloEventSetup/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<use name="Geometry/Records"/>
<export>
</export>
2 changes: 0 additions & 2 deletions PhysicsTools/IsolationAlgos/plugins/CandIsoDepositProducer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "DataFormats/TrackReco/interface/Track.h"
#include "DataFormats/MuonReco/interface/Muon.h"

#include "RecoMuon/MuonIsolation/interface/Range.h"
#include "DataFormats/RecoCandidate/interface/IsoDepositDirection.h"
#include "DataFormats/GsfTrackReco/interface/GsfTrack.h"

Expand All @@ -25,7 +24,6 @@

using namespace edm;
using namespace reco;
using namespace muonisolation;

/// constructor with config
CandIsoDepositProducer::CandIsoDepositProducer(const ParameterSet &par)
Expand Down
1 change: 0 additions & 1 deletion PhysicsTools/IsolationAlgos/plugins/CandViewExtractor.cc
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#include "CandViewExtractor.h"

#include "RecoMuon/MuonIsolation/interface/Range.h"
#include "DataFormats/RecoCandidate/interface/IsoDepositDirection.h"
#include "DataFormats/Common/interface/Handle.h"
#include "DataFormats/TrackReco/interface/Track.h"
Expand Down
2 changes: 0 additions & 2 deletions PhysicsTools/PatAlgos/plugins/PATJetProducer.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
#include "PhysicsTools/PatAlgos/interface/EfficiencyLoader.h"
#include "PhysicsTools/PatAlgos/interface/KinResolutionsLoader.h"

#include "RecoJets/JetProducers/interface/JetIDHelper.h"

#include "DataFormats/PatCandidates/interface/UserData.h"
#include "PhysicsTools/PatAlgos/interface/PATUserDataHelper.h"

Expand Down
1 change: 0 additions & 1 deletion RecoBTag/Combined/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<library file="*.cc" name="RecoBTagCombinedPlugins">
<use name="lwtnn"/>
<use name="boost"/>
Expand Down
1 change: 0 additions & 1 deletion RecoBTag/FeatureTools/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<library file="*.cc" name="RecoBTagFeatureToolsPlugins">
<use name="DataFormats/BTauReco"/>
<use name="DataFormats/Common"/>
Expand Down
1 change: 0 additions & 1 deletion RecoBTag/ImpactParameter/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
<use name="RecoVertex/GhostTrackFitter"/>
<use name="RecoBTau/JetTagComputer"/>
<use name="RecoBTag/TrackProbability"/>
<use name="RecoBTag/XMLCalibration"/>
<use name="boost"/>
<library file="*.cc" name="RecoBTagImpactParameterPlugins">
<flags EDM_PLUGIN="1"/>
Expand Down
2 changes: 0 additions & 2 deletions RecoBTag/ImpactParameter/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@

<use name="clhep"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/Utilities"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/Math"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/GeometryVector"/>
<library file="IPAnalyzer.cc" name="IPAnalyzer">
<flags EDM_PLUGIN="1"/>
</library>
1 change: 0 additions & 1 deletion RecoBTag/MXNet/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<library file="*.cc" name="RecoBTagMXNetPlugins">
<use name="DataFormats/BTauReco"/>
<use name="PhysicsTools/MXNet"/>
Expand Down
1 change: 0 additions & 1 deletion RecoBTag/ONNXRuntime/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<library file="*.cc" name="RecoBTagONNXRuntimePlugins">
<use name="DataFormats/BTauReco"/>
<use name="PhysicsTools/ONNXRuntime"/>
Expand Down
4 changes: 0 additions & 4 deletions RecoBTag/PerformanceDB/bin/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<use name="CondFormats/PhysicsToolsObjects"/>
<use name="RecoBTag/Records"/>
<use name="CondFormats/DataRecord"/>
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
<use name="RecoBTag/PerformanceDB"/>
<use name="PhysicsTools/CondLiteIO"/>
<use name="PhysicsTools/FWLite"/>
Expand Down
3 changes: 0 additions & 3 deletions RecoBTag/PerformanceDB/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<use name="CondFormats/PhysicsToolsObjects"/>
<use name="RecoBTag/Records"/>
<use name="CondFormats/DataRecord"/>
<use name="DataFormats/PatCandidates"/>
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
<use name="RecoBTag/PerformanceDB"/>
<library file="*.cc" name="testRecoBTagTestPerformanceDBPlugins">
<flags EDM_PLUGIN="1"/>
Expand Down
5 changes: 0 additions & 5 deletions RecoBTag/SoftLepton/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
<use name="RecoBTag/SoftLepton"/>
<use name="DataFormats/TrackReco"/>
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
<use name="MagneticField/Engine"/>
<use name="MagneticField/Records"/>
<use name="SimDataFormats/TrackingAnalysis"/>
<use name="SimTracker/Records"/>
<use name="SimTracker/TrackAssociation"/>
<use name="boost"/>
<library file="testLeptonAssociator.cc" name="testLeptonAssociator">
<flags EDM_PLUGIN="1"/>
Expand Down
1 change: 0 additions & 1 deletion RecoBTag/TensorFlow/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<library file="*.cc" name="RecoBTagTensorFlowPlugins">
<use name="DataFormats/BTauReco"/>
<use name="RecoBTag/TensorFlow"/>
Expand Down
1 change: 0 additions & 1 deletion RecoBTag/TrackProbability/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<use name="clhep"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/Utilities"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
Expand Down
7 changes: 3 additions & 4 deletions RecoCaloTools/Navigation/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
<use name="Geometry/CaloGeometry"/>
<use name="Geometry/CaloTopology"/>
<use name="DataFormats/HcalDetId"/>
<use name="DataFormats/EcalDetId"/>
<use name="FWCore/Framework"/>
<use name="Geometry/Records"/>
<use name="Geometry/CaloEventSetup"/>
<use name="Geometry/CaloTopology"/>
<use name="RecoCaloTools/Navigation"/>
<flags EDM_PLUGIN="1"/>
<library file="stubs/CaloNavigationAnalyzer.cc" name="testCaloNavigationAnalyzer">
</library>
39 changes: 37 additions & 2 deletions RecoCaloTools/Navigation/test/stubs/CaloNavigationAnalyzer.cc
Original file line number Diff line number Diff line change
@@ -1,6 +1,40 @@
#include "RecoCaloTools/Navigation/test/stubs/CaloNavigationAnalyzer.h"
// system include files
#include <memory>

#include "FWCore/Framework/interface/MakerMacros.h"
// user include files
#include "FWCore/Framework/interface/Frameworkfwd.h"
#include "FWCore/Framework/interface/EDAnalyzer.h"

#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/Framework/interface/ESHandle.h"

#include "FWCore/ParameterSet/interface/ParameterSet.h"

#include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h"
#include "Geometry/CaloTopology/interface/CaloSubdetectorTopology.h"
#include "Geometry/CaloTopology/interface/CaloTopology.h"
#include "RecoCaloTools/Navigation/interface/EcalBarrelNavigator.h"
#include "RecoCaloTools/Navigation/interface/EcalEndcapNavigator.h"
#include "RecoCaloTools/Navigation/interface/EcalPreshowerNavigator.h"
#include "RecoCaloTools/Navigation/interface/CaloTowerNavigator.h"
#include "DataFormats/EcalDetId/interface/EcalSubdetector.h"
#include "DataFormats/EcalDetId/interface/EBDetId.h"
#include "DataFormats/EcalDetId/interface/EEDetId.h"
#include "DataFormats/EcalDetId/interface/ESDetId.h"

#include <iostream>

class CaloNavigationAnalyzer : public edm::EDAnalyzer {
public:
explicit CaloNavigationAnalyzer(const edm::ParameterSet&);
~CaloNavigationAnalyzer();

virtual void analyze(const edm::Event&, const edm::EventSetup&);

private:
int pass_;
};

//
// constructors and destructor
Expand Down Expand Up @@ -131,4 +165,5 @@ void CaloNavigationAnalyzer::analyze(const edm::Event& iEvent, const edm::EventS
}

//define this as a plug-in
#include "FWCore/Framework/interface/MakerMacros.h"
DEFINE_FWK_MODULE(CaloNavigationAnalyzer);
41 changes: 0 additions & 41 deletions RecoCaloTools/Navigation/test/stubs/CaloNavigationAnalyzer.h

This file was deleted.

1 change: 0 additions & 1 deletion RecoEgamma/EgammaElectronProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<use name="DataFormats/BeamSpot"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/DetId"/>
<use name="DataFormats/EcalRecHit"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/EgammaReco"/>
Expand Down
2 changes: 0 additions & 2 deletions RecoEgamma/EgammaHFProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/PluginManager"/>
<use name="Geometry/CaloGeometry"/>
<use name="DataFormats/EgammaReco"/>
<use name="Geometry/Records"/>
<use name="DataFormats/RecoCandidate"/>
<use name="SimDataFormats/GeneratorProducts"/>
<use name="root"/>
<library file="*.cc" name="RecoEgammaEgammaHFProducersPlugins">
<flags EDM_PLUGIN="1"/>
Expand Down
3 changes: 0 additions & 3 deletions RecoEgamma/ElectronIdentification/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ServiceRegistry"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CondFormats/DataRecord"/>
<use name="CondFormats/EgammaObjects"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/EcalRecHit"/>
<use name="root"/>
Expand Down
5 changes: 0 additions & 5 deletions RecoEgamma/ElectronIdentification/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ServiceRegistry"/>
<use name="CondFormats/DataRecord"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/EcalRecHit"/>
<use name="CommonTools/UtilAlgos"/>
<use name="root"/>
<use name="rootcore"/>
<use name="RecoEgamma/ElectronIdentification"/>
Expand Down
3 changes: 0 additions & 3 deletions RecoEgamma/Examples/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<use name="RecoEgamma/EgammaElectronAlgos"/>
<use name="RecoEgamma/EgammaMCTools"/>
<use name="RecoEcal/EgammaCoreTools"/>
<use name="RecoTracker/TkDetLayers"/>
<use name="SimTracker/TrackAssociation"/>
<use name="Geometry/CaloGeometry"/>
<use name="Geometry/CaloTopology"/>
<use name="Geometry/CommonDetUnit"/>
Expand Down Expand Up @@ -32,7 +30,6 @@
<use name="DataFormats/JetReco"/>
<use name="DataFormats/Math"/>
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/SiStripDetId"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="DataFormats/TrackingRecHit"/>
Expand Down
Loading