Remove remaining unneeded dependencies from Reco subsystems

[guitargeek]

PR description:

Another quick round of automatic BuildFile.xml cleaning to improve the modularity of CMSSW.

Now, all of the Reco* Build files don't use dependencies anymore which are not included in the source files.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29053/13930

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalCalo/EcalRecProducers/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalTracker/SiPixelRecHits/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoPixelVertexing/PixelTrackFitting/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQMOffline/JetMET
RecoEgamma/PhotonIdentification
RecoHGCal/TICL
RecoHI/HiEgammaAlgos
RecoJets/FFTJetAlgorithms
RecoJets/JetAlgorithms
RecoJets/JetAnalyzers
RecoJets/JetProducers
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/Castor
RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoLocalFastTime/FTLClusterizer
RecoLocalFastTime/FTLCommonAlgos
RecoLocalFastTime/FTLRecProducers
RecoLocalFastTime/Records
RecoLocalTracker/ClusterParameterEstimator
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/Records
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripRecHitConverter
RecoLocalTracker/SiStripZeroSuppression
RecoLocalTracker/SubCollectionProducers
RecoLuminosity/LumiProducer
RecoMET/METPUSubtraction
RecoMTD/DetLayers
RecoMTD/MeasurementDet
RecoMTD/Navigation
RecoMTD/Records
RecoMTD/TimingIDTools
RecoMTD/TrackExtender
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFClusterTools
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelTriplets
RecoRomanPot/RecoFP420
RecoTracker/MkFit

@perrotta, @andrius-k, @kmaeshima, @schneiml, @kpedro88, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @yslai, @felicepantaleo, @jainshilpi, @hatakeyamak, @robervalwalsh, @argiro, @mschrode, @pfs, @ahinzmann, @threus, @varuns23, @seemasharmafnal, @sobhatta, @mmarionncern, @sethzenz, @jdolen, @pieterdavid, @lgray, @apsallid, @yenjie, @rociovilar, @yduhm, @cbernet, @vandreev11, @Sam-Harper, @afiqaize, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @nhanvtran, @gkasieczka, @deguio, @schoef, @alesaggio, @ebrondol, @dgulhan, @clelange, @jdamgov, @mandrenguyen, @riga, @gbenelli, @jazzitup, @edjtscott, @makortel, @dkotlins, @lecriste, @kurtejung, @gpetruc, @mariadalfonso, @yetkinyilmaz, @mmusich, @bachtis this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[guitargeek]

The test got somehow stuck it seems

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4928/console Started: 2020/02/28 10:25

[cmsbuild]

+1
Tested at: 03b47e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88bcf8/4928/summary.html
CMSSW: CMSSW_11_1_X_2020-02-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88bcf8/5051/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680577
• DQMHistoTests: Total failures: 38
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680220
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #29053 2477826

• technical updates
• no changes expected; no [relevant] changes observed

[jfernan2]

+1

[pohsun]

+1

[slava77]

@kpedro88
an upgrade signature is missing.
Please check this PR.
Thank you.

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1