Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side navigation parent items collapse when a descendant item is collapsed via keyboard #62

Closed
AlexSkrypnyk opened this issue Feb 22, 2023 · 0 comments · Fixed by #111 or #114
Closed

Side navigation parent items collapse when a descendant item is collapsed via keyboard #62

AlexSkrypnyk opened this issue Feb 22, 2023 · 0 comments · Fixed by #111 or #114
Assignees
@joshua-salsadigital
Labels
State: Confirmed The issue was triaged and confirmed for development State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Milestone
1.8

Comments

@AlexSkrypnyk
Copy link
Contributor

AlexSkrypnyk commented Feb 22, 2023 •
edited
Loading

Pressing an enter key on the collapsible trigger correctly closes opened collapsible in only current level (in Sidebar navigation, for example)

Pressing spacebar closes all levels, but should do what pressing the enter key does

collapsible.trigger.1.mov
open.sidebar.1.mov
@AlexSkrypnyk AlexSkrypnyk transferred this issue from civictheme/monorepo-drupal Jan 18, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [DEFECT] Collapsible acts differently on spacebar and enter keys Collapsible acts differently on spacebar and enter keys Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk added the State: Needs triage An issue or PR has not been assessed and requires a triage label Jan 19, 2024
@fionamorrison23 fionamorrison23 added State: Confirmed The issue was triaged and confirmed for development and removed State: Needs triage An issue or PR has not been assessed and requires a triage labels Mar 7, 2024
@fionamorrison23 fionamorrison23 added this to the 1.8 milestone Mar 7, 2024
@joshua-salsadigital joshua-salsadigital mentioned this issue Mar 14, 2024
Merged
7 tasks
@AlexSkrypnyk AlexSkrypnyk changed the title Collapsible acts differently on spacebar and enter keys Side navigation parent items collapse when a descendant item is collapsed via keyboard Mar 15, 2024
@civictheme civictheme deleted a comment from fionamorrison23 Mar 15, 2024
AlexSkrypnyk pushed a commit that referenced this issue Mar 15, 2024
@joshua-salsadigital
[#62] Fixed closing of the descendant item with a keyboard collapsing…
6431820 
… ancestor items in Side Navigation component. (#111)

Co-authored-by: Joshua Fernandes <“joshua.1234511@yahoo.in”>
@github-project-automation github-project-automation bot moved this to Done in UI Kit Mar 15, 2024
joshua-salsadigital pushed a commit that referenced this issue Mar 15, 2024
[#62] Fixed For navigation, accordion and side bar components - UP do…
068fa07 
…es not close open menu/accordion.
joshua-salsadigital pushed a commit that referenced this issue Mar 15, 2024
[#62] Fixed For navigation, accordion and side bar components - UP do…
a67b836 
…es not close open menu/accordion.
@joshua-salsadigital joshua-salsadigital mentioned this issue Mar 15, 2024
Merged
7 tasks
joshua-salsadigital pushed a commit that referenced this issue Mar 15, 2024
[#62] Fixed For navigation, accordion and side bar components - UP do…
c2b19eb 
…es not close open menu/accordion.
AlexSkrypnyk pushed a commit that referenced this issue Mar 15, 2024
@joshua-salsadigital
[#62] Fix "up" key does not close open menu/accordion. (#114)
b3f22a2 
Co-authored-by: Joshua Fernandes <“joshua.1234511@yahoo.in”>
@AlexSkrypnyk AlexSkrypnyk added the State: Done The issue is complete and waiting for a release label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-salsadigital joshua-salsadigital

Labels
State: Confirmed The issue was triaged and confirmed for development State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Projects
UI Kit
Status: Done
Milestone
1.8
3 participants
@AlexSkrypnyk @joshua-salsadigital @fionamorrison23