Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#62] Fixed closing of the descendant item with a keyboard collapsing ancestor items in Side Navigation component. #111

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 14, 2024

Closes #62

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Fixed Collapsible acts differently on spacebar and enter keys.

Screenshots

@joshua-salsadigital joshua-salsadigital added the PR: Needs review Pull request needs a review from assigned developers label Mar 14, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Mar 14, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request March 14, 2024 12:08 Inactive
@joshua-salsadigital
Copy link
Collaborator Author

@AlexSkrypnyk AlexSkrypnyk changed the title [62] Fixed Collapsible acts differently on spacebar and enter keys. [#62] Fixed closing of the descendant item with a keyboard collapsing ancestor items in Side Navigation component. Mar 15, 2024
@AlexSkrypnyk
Copy link
Contributor

@joshua-salsadigital
This fix is so elegant! 💅

@AlexSkrypnyk AlexSkrypnyk merged commit 6431820 into main Mar 15, 2024
5 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/62-fix-spacebar-event branch March 15, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side navigation parent items collapse when a descendant item is collapsed via keyboard
2 participants