[#62] Fixed For navigation, accordion and side bar components - UP does not close open menu/accordion. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not close open menu/accordion.
joshua-salsadigital
added
the
PR: Needs review
…es not close open menu/accordion.
| @@ -255,7 +255,11 @@ CivicThemeCollapsible.prototype.collapse = function (animate, evt) { | |||
| } | |||
|
|
|||
| if (evt && evt.target) { | |||
| if (evt.currentTarget !== t.el || evt.target !== t.el) { | |||
| if (evt.detail.keydown) { | |||
| if (evt.target.closest('li') !== t.el) { | |||
There was a problem hiding this comment.
@joshua-salsadigital
we cannot target elements by tag as it will not be portable - collapsible is not aware on which components it is used. please find another way to solve this
AlexSkrypnyk
added
PR: Requires more work
joshua-salsadigital
added
PR: Needs review
AlexSkrypnyk
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.Changedsection about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots
https://nimb.ws/kouGV6B