Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label, Field description, Field message - Update to use centralised helpers #125

Closed
AlexSkrypnyk opened this issue Mar 27, 2024 · 2 comments
Closed

Label, Field description, Field message - Update to use centralised helpers #125

AlexSkrypnyk opened this issue Mar 27, 2024 · 2 comments
Assignees
@AlexSkrypnyk
Labels
State: Done The issue is complete and waiting for a release Type: Chore Issue is a related to a maintenance
Milestone
1.8

Comments

@AlexSkrypnyk
Copy link
Contributor

AlexSkrypnyk commented Mar 27, 2024 •
edited
Loading

See epic: #121

SD

  1. Update Label, Field description, Field message components to use new helpers instead of using their own and decommission existing helpers.
  2. Update Label to support for attribute and required indicator + update stories. See this code for reference
  3. Update Field description to use 2 sizes (large, regular) + update stories. See this code for reference

Note that updating components, which use these 3 components, is not required as those components will be refactored in other issues.
@AlexSkrypnyk AlexSkrypnyk mentioned this issue Mar 27, 2024
Closed
@AlexSkrypnyk AlexSkrypnyk added this to the 1.8 milestone Mar 27, 2024
@AlexSkrypnyk AlexSkrypnyk added Type: Chore Issue is a related to a maintenance State: Confirmed The issue was triaged and confirmed for development labels Mar 27, 2024
This was referenced Mar 27, 2024
Closed
Closed
Closed
@fionamorrison23 fionamorrison23 moved this to Todo in UI Kit Apr 8, 2024
@joshua-salsadigital joshua-salsadigital mentioned this issue Apr 23, 2024
Merged
7 tasks
joshua-salsadigital pushed a commit that referenced this issue Apr 23, 2024
[#125] Label, Field description, Field message - Updated to use centr…
8ec73c1 
…alised helpers
AlexSkrypnyk pushed a commit that referenced this issue May 7, 2024
@joshua-salsadigital
[#124] [#125] [#127] Created/Updated centralised Storybook helpers. (#…
bf38e41 
…139)

Co-authored-by: Joshua Fernandes <“joshua.1234511@yahoo.in”>
@AlexSkrypnyk
Copy link
Contributor Author

@sonamchaturvedi28
Could you please test this in DEV

@AlexSkrypnyk AlexSkrypnyk added State: In progress The issue is being worked on and removed State: Confirmed The issue was triaged and confirmed for development labels May 7, 2024
@AlexSkrypnyk AlexSkrypnyk moved this from Todo to In Progress in UI Kit May 7, 2024
@sonamchaturvedi28
Copy link

Test Env: DEV
Test Status: PASS
Test Result:
1. Verified Label, Field description, Field message components and they are working fine
2. for attribute and required indicator are added for Label component
3. Field description uses 2 sizes (large, regular)

image image image

@fionamorrison23 fionamorrison23 added PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) and removed State: In progress The issue is being worked on labels May 15, 2024
@fionamorrison23 fionamorrison23 moved this from In Progress to Done in UI Kit May 30, 2024
@fionamorrison23 fionamorrison23 added State: Done The issue is complete and waiting for a release and removed PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexSkrypnyk AlexSkrypnyk

Labels
State: Done The issue is complete and waiting for a release Type: Chore Issue is a related to a maintenance
Projects
UI Kit
Status: Done
Milestone
1.8
Development

No branches or pull requests
4 participants
@AlexSkrypnyk @sonamchaturvedi28 @joshua-salsadigital @fionamorrison23