Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox - Update to design 1.7 #67

Closed
AlexSkrypnyk opened this issue Jan 19, 2024 · 4 comments · Fixed by #203
Closed

Checkbox - Update to design 1.7 #67

AlexSkrypnyk opened this issue Jan 19, 2024 · 4 comments · Fixed by #203
Assignees
Labels
State: Confirmed The issue was triaged and confirmed for development Type: Chore Issue is a related to a maintenance
Milestone

Comments

@AlexSkrypnyk
Copy link
Contributor

AlexSkrypnyk commented Jan 19, 2024

See epic: #121

We are looking for a bulletproof, icon-less and customisable implementation of a checkbox using CSS-only.

SD

  1. Update the implementation to match all states in Figma v1.7.0. Note that some of the states were fixed in Figma, so these should be reflected in code. Use this code for reference.
  2. Update component to correctly use updated Label's props for for and required.
  3. Update component to use new helpers instead of using its own and decommission existing helpers.
@AlexSkrypnyk AlexSkrypnyk added State: Needs triage An issue or PR has not been assessed and requires a triage State: Confirmed The issue was triaged and confirmed for development and removed State: Needs triage An issue or PR has not been assessed and requires a triage labels Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk added this to the 1.7 milestone Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk moved this to Todo in UI Kit Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk removed the status in UI Kit Jan 19, 2024
@fionamorrison23 fionamorrison23 moved this to Todo in UI Kit Jan 22, 2024
@fionamorrison23 fionamorrison23 modified the milestones: 1.7, 1.8 Feb 15, 2024
@fionamorrison23 fionamorrison23 modified the milestones: 1.8, 1.7 Mar 6, 2024
@fionamorrison23 fionamorrison23 added the Type: Feature Issue is a new feature request label Mar 7, 2024
@fionamorrison23 fionamorrison23 moved this from Todo to In Progress in UI Kit Mar 19, 2024
@AlexSkrypnyk AlexSkrypnyk added State: In progress The issue is being worked on State: In review Issue is being reviewed and removed State: Confirmed The issue was triaged and confirmed for development State: In progress The issue is being worked on labels Mar 25, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title Update checkboxes to the design changes in 1.7.0 Checkbox - Update to design 1.7 Mar 27, 2024
@AlexSkrypnyk AlexSkrypnyk removed the Type: Feature Issue is a new feature request label Mar 27, 2024
@AlexSkrypnyk AlexSkrypnyk added Type: Chore Issue is a related to a maintenance State: Confirmed The issue was triaged and confirmed for development and removed State: In review Issue is being reviewed labels Mar 27, 2024
@AlexSkrypnyk AlexSkrypnyk moved this from In Progress to Todo in UI Kit Mar 27, 2024
@fionamorrison23
Copy link
Collaborator

Awaiting design.

@fionamorrison23 fionamorrison23 added the BLOCKED Issue or pull request is blocked label Apr 8, 2024
@fionamorrison23 fionamorrison23 removed the BLOCKED Issue or pull request is blocked label May 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in UI Kit Jun 12, 2024
@sonamchaturvedi28
Copy link

Test Env: DEV
Test Status: FAIL
Test Result:

  1. Border radius of checkbox is 2px. Expected is 4px as per Figma.
  2. Checkbox border and background colour for Disabled Checked state is incorrect. It should be same as Disabled unchecked state

Issue#1:
image

Issue#2:
Screenshot 2024-06-13 at 10 45 09 AM

@fionamorrison23 fionamorrison23 moved this from Done to In Progress in UI Kit Jun 13, 2024
@AlexSkrypnyk
Copy link
Contributor Author

  1. Acknowledged. Fixed now. Also, some sub-pixel sizing dimensions were fixed.
Cursor_and_Molecules___Field_-_Field_⋅_Storybook
  1. We are not updating the background for the disabled state - we are making the whole control semi-transparent. This is an industry standard practice as it also takes care of the label.

@github-project-automation github-project-automation bot moved this from In Progress to Done in UI Kit Jun 13, 2024
@sonamchaturvedi28
Copy link

Test Env: DEV
Test Status: PASS
Test Result:

  • Retested issue#1 and it is fixed, border radius of checkbox is 4px.
  • Border width pixel is also now better.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Confirmed The issue was triaged and confirmed for development Type: Chore Issue is a related to a maintenance
Projects
Status: Done
4 participants