[#124] [#125] [#127] Created/Updated centralised Storybook helpers. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/00-base/base.stories.js
Outdated
|
|
||
| export const capitalizeFirstLetter = (string) => string.charAt(0).toUpperCase() + string.slice(1); | ||
|
|
||
| export const indexedString = 'PlaceholderText'; |
There was a problem hiding this comment.
Not sure of this function.
Is this referencing to https://www.w3schools.com/jsref/jsref_indexof.asp. ??
components/00-base/base.stories.js
Outdated
There was a problem hiding this comment.
NoMetaError: CSF: missing default export (line 1, col 0)
Can eb reolved with
export default {
title: 'Base',
};
but since this is not a story we cannot add export default.
joshua-salsadigital
added
PR: Needs review
joshua-salsadigital
changed the title
joshua-salsadigital
changed the title
joshua-salsadigital
changed the title
AlexSkrypnyk
suggested changes
May 7, 2024
| @@ -36,7 +36,7 @@ export const Label = (knobTab) => { | |||
| ), | |||
| content: text('Content', 'Label content', generalKnobTab), | |||
| for: text('For', '', generalKnobTab), | |||
| is_required: boolean('Required', false, generalKnobTab), | |||
There was a problem hiding this comment.
please revert. All boolean props are prefixed with is_ on purpose
AlexSkrypnyk
added
PR: Requires more work
|
@joshua-salsadigital |
joshua-salsadigital
added
PR: Needs review
AlexSkrypnyk
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.Changedsection about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots