Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added polkadot multisig client #2341

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Conversation

j4m1ef0rd
Copy link
Contributor

@j4m1ef0rd j4m1ef0rd commented Oct 26, 2022

Closses #2288
Part of #2285

  • Create and spawn the polkadot multisig client
  • Added polkadot channels to the p2p muxer
  • Give the polkadot client to the SCObserver
  • When eth ceremony requests come in, I trigger an update of polkadot's ceremony id tracking. Same will have to happen when we get eth ceremony requests.

Shortcomings:

  • Could not put the polkadot client behind the ibiza feature flag due to it being to interwoven with the muxer and the SCObserver arguments and return values.
  • Did not hook up the SCObserver events to use the new polkadot client. No sending the ceremony outcomes either.
  • No unit tests. not sure if we need any because all of the functionality is tested at a low level (muxer, crypto_scheme, etc..)

@j4m1ef0rd j4m1ef0rd added the CFE label Oct 26, 2022
@j4m1ef0rd j4m1ef0rd requested review from msgmaxim and kylezs October 26, 2022 03:23
@j4m1ef0rd j4m1ef0rd self-assigned this Oct 26, 2022
@msgmaxim
Copy link
Contributor

Could not put the polkadot client behind the ibiza feature flag due to it being to interwoven with the muxer and the SCObserver arguments and return values.

I don't think it needs to be behind a flag. It doesn't break any existing features and it won't have any unwanted side effects.

@j4m1ef0rd j4m1ef0rd marked this pull request as ready for review October 26, 2022 23:26
Co-authored-by: kylezs <kyle@chainflip.io>
@j4m1ef0rd j4m1ef0rd merged commit f8354f7 into develop Oct 28, 2022
@j4m1ef0rd j4m1ef0rd deleted the feat/polkadot-miltisig-client branch October 28, 2022 02:21
dandanlen pushed a commit that referenced this pull request Nov 7, 2022
Co-authored-by: kylezs <kyle@chainflip.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants