Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added polkadot to genesis keys script #2352

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Added polkadot to genesis keys script #2352

merged 2 commits into from
Oct 28, 2022

Conversation

j4m1ef0rd
Copy link
Contributor

@j4m1ef0rd j4m1ef0rd commented Oct 27, 2022 •
edited by gitpod-io bot
Loading

Closes #2341

  • Changed the guts of the genesis code to be generic for the crypto scheme
  • Made it generate and save both eth and polkadot keys for each node. both keys in the same db file.
  • Added a small unit test to help make sure it works.

Side note: Was not able to use the cfg test stuff from the chainflip_engine crate. Found a related issue here

@j4m1ef0rd j4m1ef0rd requested a review from kylezs October 27, 2022 04:18
@j4m1ef0rd j4m1ef0rd self-assigned this Oct 27, 2022
@kylezs kylezs linked an issue Oct 27, 2022 that may be closed by this pull request
generate genesis key shares for polkadot #2346
Closed
kylezs
kylezs reviewed Oct 27, 2022
View reviewed changes
@kylezs kylezs merged commit c4dbffc into develop Oct 28, 2022
@kylezs kylezs deleted the feature/add-polkadot-genisis-keys branch October 28, 2022 12:12
j4m1ef0rd added a commit that referenced this pull request Nov 3, 2022
@j4m1ef0rd
Added polkadot to genesis keys script (#2352)
c164864 
* feat: added polkadot to genesis keys script

* refactor: both keys in same json object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylezs kylezs kylezs approved these changes

Assignees

@j4m1ef0rd j4m1ef0rd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate genesis key shares for polkadot
2 participants
@j4m1ef0rd @kylezs