Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polkadot Keygen #2285

Closed
dandanlen opened this issue Oct 14, 2022 · 1 comment · Fixed by #2545
Closed

Add Polkadot Keygen #2285

dandanlen opened this issue Oct 14, 2022 · 1 comment · Fixed by #2545
Labels
effort-8 Highly likely to encounter unknown unknowns State Chain

Comments

@dandanlen
Copy link
Collaborator

Description

Our CFE is already capable of generating polkadot keys but we don't currently emit a request to do so.

Worth waiting for or branching off #2218 for this.

Something like:

  • Add required ChainApi members for vault rotations (SetAggKeyWithAggKey equivalent).
  • impl VaultRotator for (T1, T2) where T1: VaultRotator, T2: VaultRotator (or equivalent). This should ensure that we wait until the keygen for both chains is successful before emitting the rotation transaction.
  • Add a new polkadot pallet instances for vault, threshold signer and broadcaster, link everything together.

Out of scope:

The CFE doesn't have to be able to send the rotation transaction or witness anything yet.

The main thing is being able to generate a new polkadot AggKey. The can 'confirm' it without actually broadcasting anything.

Relevant people

@kylezs @ramizhasan111 might be worth looking at this together.

@dandanlen dandanlen added State Chain effort-5 Some known unknowns, will require some research labels Oct 14, 2022
@dandanlen dandanlen changed the title Add Polkdatod Keygen Add Polkadot Keygen Oct 14, 2022
@kylezs kylezs added effort-8 Highly likely to encounter unknown unknowns and removed effort-5 Some known unknowns, will require some research labels Oct 14, 2022
@msgmaxim
Copy link
Contributor

Created #2288 as there is still a bit of work left before CFE is ready to process Polkadot requests. The work can mostly proceed in parallel though we probably shouldn't actually start sending polkadot requests before #2288 is merged. At the same time #2288 requires polkadot vault/events to be added so we can "subscribe" to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-8 Highly likely to encounter unknown unknowns State Chain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants