Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): Update addon-storysource for renamed Layout Modules #1108

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

lily-peng
Copy link
Contributor

Pull request - Since this PR (#1013), code samples for Layout Modules have not been working. I added a configuration to addon-storysource to account for the renamed files.

Testing instructions

  • In Storybook, check that you can see source code under the Story tab in the Canvas for all components, including Layout Module components such as ListItemModule.
  • Also for Layout Modules, check the Docs tab to see the "Hide Code" buttons after stories and their corresponding source code.

@lily-peng lily-peng requested a review from a team as a code owner October 1, 2021 19:07
@lily-peng lily-peng requested review from j1mie and SimonFinney and removed request for a team October 1, 2021 19:07
@netlify
Copy link

netlify bot commented Oct 1, 2021

✔️ Deploy Preview for ibm-security ready!

🔨 Explore the source changes: 38a883d

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/615efefc435160000733fda5

😎 Browse the preview: https://deploy-preview-1108--ibm-security.netlify.app/

Copy link

@cameroncalder cameroncalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Lily! 🙏

Copy link
Contributor

@SimonFinney SimonFinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! I had one suggestion.

Copy link
Contributor

@SimonFinney SimonFinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thank you! 💯

@kodiakhq kodiakhq bot merged commit 8a3933a into dev Oct 7, 2021
@kodiakhq kodiakhq bot deleted the storysource-layoutmodules-fix branch October 7, 2021 14:23
SimonFinney pushed a commit that referenced this pull request Oct 7, 2021
# [1.45.0-prerelease.10](v1.45.0-prerelease.9...v1.45.0-prerelease.10) (2021-10-07)

### Bug Fixes

* **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a))
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.45.0-prerelease.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimonFinney pushed a commit that referenced this pull request Oct 13, 2021
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13)

### Bug Fixes

* **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9))
* **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542))
* **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584))
* **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a))
* **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055))
* **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591))

### Features

* **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da))
* **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b))
* **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a))

### Reverts

* Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116)
* Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants