-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storybook): Update addon-storysource for renamed Layout Modules #1108
Conversation
✔️ Deploy Preview for ibm-security ready! 🔨 Explore the source changes: 38a883d 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/615efefc435160000733fda5 😎 Browse the preview: https://deploy-preview-1108--ibm-security.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you Lily! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring this out! I had one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — thank you! 💯
# [1.45.0-prerelease.10](v1.45.0-prerelease.9...v1.45.0-prerelease.10) (2021-10-07) ### Bug Fixes * **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a))
🎉 This PR is included in version 1.45.0-prerelease.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13) ### Bug Fixes * **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9)) * **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542)) * **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584)) * **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a)) * **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055)) * **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591)) ### Features * **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da)) * **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b)) * **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a)) ### Reverts * Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116) * Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
🎉 This PR is included in version 1.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull request - Since this PR (#1013), code samples for Layout Modules have not been working. I added a configuration to addon-storysource to account for the renamed files.
Testing instructions