feat(decorator): add onContextMenu to decorator #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urity into add-oncontextmenu-to-decorator
paul-balchin-ibm
requested review from
areddon
and removed request for
a team
|
✔️ Deploy Preview for ibm-security ready! 🔨 Explore the source changes: de80f41 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/613b55390cf2010007a8c7d2 😎 Browse the preview: https://deploy-preview-1102--ibm-security.netlify.app/ |
|
✔️ Deploy Preview for ibm-security ready! 🔨 Explore the source changes: 7a2fbcd 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/613f42420ac93300072ebbef 😎 Browse the preview: https://deploy-preview-1102--ibm-security.netlify.app |
areddon
approved these changes
Sep 10, 2021
SimonFinney
reviewed
Sep 11, 2021
src/components/DataDecorator/Decorator/__tests__/Decorator-test.js
Outdated
Show resolved
Hide resolved
SimonFinney
reviewed
Sep 11, 2021
src/components/DataDecorator/Decorator/__tests__/Decorator-test.js
Outdated
Show resolved
Hide resolved
SimonFinney
approved these changes
Sep 11, 2021
…t.js Co-authored-by: Simon Finney <simonjfinney@gmail.com>
…t.js Co-authored-by: Simon Finney <simonjfinney@gmail.com>
Of course. Thanks for seeing that. |
SimonFinney
pushed a commit
that referenced
this pull request
Sep 13, 2021
# [1.45.0-prerelease.7](v1.45.0-prerelease.6...v1.45.0-prerelease.7) (2021-09-13) ### Features * **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da))
|
🎉 This PR is included in version 1.45.0-prerelease.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SimonFinney
pushed a commit
that referenced
this pull request
Oct 13, 2021
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13) ### Bug Fixes * **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9)) * **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542)) * **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584)) * **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a)) * **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055)) * **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591)) ### Features * **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da)) * **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b)) * **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a)) ### Reverts * Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116) * Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
|
🎉 This PR is included in version 1.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request - Added onContextMenu callback function to remaining states
Proposed changes
hrefspanTesting instructions
span,href, orbutton), if anonContextMenuprop is defined, a callback should be triggered.