fix(nav-item-link): remove fixed height to prevent issues with multi-line text #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ibm-security ready! 🔨 Explore the source changes: 2440670 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/611e2e4bb9f1870007cb98c9 😎 Browse the preview: https://deploy-preview-1085--ibm-security.netlify.app/ |
dbrugger
force-pushed
the
nav-item-height
branch
from
9bae258 to
d18f5be
Compare
clairek20
approved these changes
Aug 19, 2021
SimonFinney
pushed a commit
that referenced
this pull request
Aug 19, 2021
# [1.45.0-prerelease.3](v1.45.0-prerelease.2...v1.45.0-prerelease.3) (2021-08-19) ### Bug Fixes * **header:** set aria-expanded and aria-haspopup on the appropriate element ([#1074](#1074)) ([203a627](203a627)) * **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542)) ### Features * **deps:** upgrade Carbon to 10.41 ([3d17520](3d17520)) * **styles:** deprecate body, grid, and type style utility output ([#967](#967)) ([4f55c2f](4f55c2f))
|
🎉 This PR is included in version 1.45.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SimonFinney
pushed a commit
that referenced
this pull request
Oct 13, 2021
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13) ### Bug Fixes * **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9)) * **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542)) * **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584)) * **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a)) * **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055)) * **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591)) ### Features * **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da)) * **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b)) * **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a)) ### Reverts * Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116) * Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
|
🎉 This PR is included in version 1.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request -
Affected issues
Proposed changes
heightand use bigger top and bottompaddinginsteadNavcomponentTesting instructions