This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Adopt SkyLibResourcesProvider
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2018
Blackbaud-SteveBrush
requested review from
Blackbaud-PaulCrowder and
Blackbaud-BobbyEarl
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 100% 99.83% -0.17%
==========================================
Files 11 13 +2
Lines 600 615 +15
Branches 107 108 +1
==========================================
+ Hits 600 614 +14
- Misses 0 1 +1
Continue to review full report at Codecov.
|
blackbaud-conorwright
suggested changes
Oct 18, 2018
| "@skyux/indicators": "^3.0.0-rc.0", | ||
| "@skyux/popovers": "^3.0.0-rc.0", | ||
| "rxjs": "^5.4.3" | ||
| "@skyux/popovers": "^3.0.0-rc.0" |
There was a problem hiding this comment.
This is going to need to be updated when popovers is released using i18n 3.2.0
| @@ -30,10 +30,9 @@ | |||
| "@angular/core": "^4.3.6", | |||
| "@angular/router": "^4.3.6", | |||
| "@skyux/core": "^3.1.0", | |||
| "@skyux/i18n": "^3.0.1", | |||
| "@skyux/i18n": "^3.2.0", | |||
| "@skyux/indicators": "^3.0.0-rc.0", | |||
There was a problem hiding this comment.
this should be updated to rc.2 so that this package is fully using the libresources
| "@skyux/core": "3.1.0", | ||
| "@skyux/i18n": "3.0.1", | ||
| "@skyux/i18n": "3.2.0", | ||
| "@skyux/indicators": "3.0.0-rc.0", | ||
| "@skyux/popovers": "3.0.0-rc.0", |
There was a problem hiding this comment.
^ devDependency versions for indicators and popovers should be updated too
blackbaud-conorwright
approved these changes
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get this working, clone the
@skyux/i18n"lib-resources" branch, here: blackbaud/skyux-i18n#12skyux build-public-libraryin the skyux-i18n directorynpm link)skyux servein the skyux-lookup directoryBulider PR: blackbaud/skyux-builder#486
Builder Plugin PR: blackbaud/skyux-sdk-builder-plugin-skyux#2
SKY UX I18N PR: blackbaud/skyux-i18n#12